Conversation
jihoonson
reviewed
May 22, 2019
| * [JVM Best Practices](/docs/VERSION/configuration/index.html#jvm-configuration-best-practices) | ||
| * Tools | ||
| * [Dump Segment Tool](/docs/VERSION/operations/dump-segment.html) | ||
| * [Insert Segment Tool](/docs/VERSION/operations/insert-segment-to-db.html) |
Contributor
There was a problem hiding this comment.
Would you please remove this line? It was removed in #6911.
Contributor
Author
Contributor
Author
There was a problem hiding this comment.
I'm fine removing it as long as it is the right thing to do
Contributor
There was a problem hiding this comment.
Ah I see. It looks fine to me.
jihoonson
approved these changes
May 23, 2019
Contributor
Author
|
@jihoonson do you mind helping me backport this to 0.15? |
jihoonson
pushed a commit
to jihoonson/druid
that referenced
this pull request
May 23, 2019
Contributor
|
Sure, raised #7739. |
fjy
pushed a commit
that referenced
this pull request
May 23, 2019
jihoonson
added a commit
to implydata/druid-public
that referenced
this pull request
Jun 4, 2019
jihoonson
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jun 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.