Fix LookupSerdeModule double-binding in Coordinator-as-Overlord mode.#7765
Merged
gianm merged 1 commit intoapache:masterfrom May 26, 2019
Merged
Fix LookupSerdeModule double-binding in Coordinator-as-Overlord mode.#7765gianm merged 1 commit intoapache:masterfrom
gianm merged 1 commit intoapache:masterfrom
Conversation
gianm
added a commit
to gianm/druid
that referenced
this pull request
May 26, 2019
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
May 26, 2019
This was referenced May 27, 2019
gianm
added a commit
to gianm/druid
that referenced
this pull request
May 27, 2019
clintropolis
pushed a commit
that referenced
this pull request
May 27, 2019
himanshug
reviewed
May 28, 2019
| } else { | ||
| // Only add LookupSerdeModule if !beOverlord, since CliOverlord includes it, and having two copies causes | ||
| // the injector to get confused due to having multiple bindings for the same classes. | ||
| modules.add(new LookupSerdeModule()); |
Contributor
There was a problem hiding this comment.
that is why CliOverloard.getModules(boolean standalone) takes the standalone flag also, so that we can take care of these things in there if/when needed.
jihoonson
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jun 4, 2019
jihoonson
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jun 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7762.