Skip to content

Fix LookupSerdeModule double-binding in Coordinator-as-Overlord mode. #7765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gianm merged 1 commit into from
May 26, 2019
Merged

Fix LookupSerdeModule double-binding in Coordinator-as-Overlord mode. #7765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions services/src/main/java/org/apache/druid/cli/CliCoordinator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,10 +272,12 @@ public LoadQueueTaskMaster getLoadQueueTaskMaster(
}
);

modules.add(new LookupSerdeModule());

if (beOverlord) {
modules.addAll(new CliOverlord().getModules(false));
} else {
// Only add LookupSerdeModule if !beOverlord, since CliOverlord includes it, and having two copies causes
// the injector to get confused due to having multiple bindings for the same classes.
modules.add(new LookupSerdeModule());
Copy link
Copy Markdown
Contributor

@himanshug himanshug May 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is why CliOverloard.getModules(boolean standalone) takes the standalone flag also, so that we can take care of these things in there if/when needed.

}

return modules;
Expand Down