Skip to content

endpoint to delete lookup tier and remove tier on last lookup deletion#7852

Merged
himanshug merged 1 commit intoapache:masterfrom
himanshug:bugfix
Jun 16, 2019
Merged

endpoint to delete lookup tier and remove tier on last lookup deletion#7852
himanshug merged 1 commit intoapache:masterfrom
himanshug:bugfix

Conversation

@himanshug
Copy link
Copy Markdown
Contributor

Fixes #4940

@vogievetsky
Copy link
Copy Markdown
Contributor

Hmmm, how should this interact with the lookup view in the web console? Would it make more sense for the remove lookup tier endpoint to tidy up after itself if it is removing the last lookup in a tier?

@himanshug
Copy link
Copy Markdown
Contributor Author

@vogievetsky with this patch, on the server , a tier would automatically be deleted when last lookup in it gets deleted. so for web console, it would make sense to do so as well. Also maybe add something for calling the newly added delete tier endpoint .

@vogievetsky
Copy link
Copy Markdown
Contributor

a tier would automatically be deleted when last lookup in it gets deleted

Oh cool. That is what I was asking.

Also maybe add something for calling the newly added delete tier endpoint .

If going forward a tier will be auto deleted when the last lookup is deleted, under what circumstances would a user want to do that? Would it bulk delete all the lookups in that tier? Or did you add it as a way to remove empty tiers that might be left behind in the current version of Druid?

@himanshug
Copy link
Copy Markdown
Contributor Author

himanshug commented Jun 9, 2019

Would it bulk delete all the lookups in that tier? Or did you add it as a way to remove empty tiers that might be left behind in the current version of Druid?

both :)

Copy link
Copy Markdown
Member

@clintropolis clintropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@himanshug himanshug merged commit b3328b2 into apache:master Jun 16, 2019
jihoonson pushed a commit to implydata/druid-public that referenced this pull request Jun 26, 2019
@clintropolis clintropolis added this to the 0.16.0 milestone Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There is no way to delete lookup tiers

3 participants