bug fix for lookup leak when we remove the last lookup from lookup tier#8598
bug fix for lookup leak when we remove the last lookup from lookup tier#8598himanshug merged 4 commits intoapache:masterfrom
Conversation
|
@FaxianZhao thanks for discovering and finding the root cause. |
| try { | ||
| List<ListenableFuture<Map.Entry>> futures = new ArrayList<>(); | ||
| for (Map.Entry<String, Map<String, LookupExtractorFactoryMapContainer>> tierEntry : allLookupTiers.entrySet()) { | ||
| for (String tier : lookupNodeDiscovery.getAllTiers()) { |
There was a problem hiding this comment.
can you merge https://github.com/FaxianZhao/incubator-druid/pull/1 to add another block to note lookups that will never be loaded?
There was a problem hiding this comment.
can you merge FaxianZhao#1 to add another block to note lookups that will never be loaded?
Good idea.
But for the users who enable 'druid.lookup.lookupTierIsDatasource', will this warning confuse them?
There was a problem hiding this comment.
a quick look at the usage of that property tells me that it is not used by coordinator and shouldn't interfere.
There was a problem hiding this comment.
a quick look at the usage of that property tells me that it is not used by coordinator and shouldn't interfere.
Agree.
warnings about lookups that will never be loaded
…er (apache#8598) * bug fix for lookup leak when we remove the last lookup from lookup tier * warnings about lookups that will never be loaded * fix unit test
…er (apache#8598) * bug fix for lookup leak when we remove the last lookup from lookup tier * warnings about lookups that will never be loaded * fix unit test
4 participants
Fixes bug which caused by #7852.
Description
Fixed the bug ...
Due to #7852, coordinator won't tell other node to dispose lookup when we remove the last lookup from a tier.
Renamed the class ...
Added a forbidden-apis entry ...
This PR has:
Key changed/added classes in this PR
LookupCoordinatorManager