remove FirehoseV2 and realtime node extensions#8020
Merged
fjy merged 3 commits intoapache:masterfrom Jul 4, 2019
Merged
Conversation
clintropolis
changed the title
clintropolis
changed the title
Contributor
|
👍 |
Contributor
|
I am so stoked about this PR. Deleting code is the best. |
gianm
approved these changes
Jul 4, 2019
Contributor
gianm
left a comment
gianm
left a comment
There was a problem hiding this comment.
Reading through this diff is truly a blast from the past.
👍 , LGTM
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-up to #7915 and this dev list thread, and removes
FirehoseV2and some extensions that were only relevant for realtime nodes:druid-kafka-eight,druid-kafka-eight-simpleConsumer,druid-rabbitmq,druid-rocketmq, as well as thedruid-exampleextension.This PR has: