Skip to content

Remove commit() method Firehose#8688

Merged
fjy merged 2 commits intoapache:masterfrom
jihoonson:remove-commit
Oct 23, 2019
Merged

Remove commit() method Firehose#8688
fjy merged 2 commits intoapache:masterfrom
jihoonson:remove-commit

Conversation

@jihoonson
Copy link
Copy Markdown
Contributor

@jihoonson jihoonson commented Oct 17, 2019

Description

commit() method was implemented only by the ancient kafka firehose which was removed in #8020.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths.
  • added integration tests.
  • been tested in a test Druid cluster.

This change is Reviewable

@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Oct 17, 2019

This pull request fixes 2 alerts when merging 6038515 into 89ce638 - view on LGTM.com

fixed alerts:

  • 2 for Dereferenced variable may be null

Copy link
Copy Markdown
Contributor

@ccaominh ccaominh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Copy Markdown
Member

@clintropolis clintropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

// Do nothing
}
};
private static final Supplier<Committer> NIL_SUPPLIER = Suppliers.ofInstance(NIL);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like a smell that this class still exists and only has this nil supplier, and maybe can be removed entirely. But I'm ok if we continue clean-up in the future since this looks a bit more invasive to dump than just removing commit from the Firehose.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that we should remove the nil supplier. A follow up PR is fine as long as we remember to do it...

@fjy fjy merged commit 094936c into apache:master Oct 23, 2019
@jon-wei jon-wei added this to the 0.17.0 milestone Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants