Fix dependency analyze warnings#8128
Merged
gianm merged 14 commits intoapache:masterfrom Jul 26, 2019
Merged
Conversation
Update the maven dependency plugin to the latest version and fix all warnings for unused declared and used undeclared dependencies in the compile scope. Added new travis job to add the check to CI. Also fixed some source code files to use the correct packages for their imports.
Contributor
Author
|
Seeing flaky OutOfMemoryError in BufferHashGrouperTest (same as #8134) |
gianm
reviewed
Jul 23, 2019
| <dependency> | ||
| <groupId>commons-io</groupId> | ||
| <artifactId>commons-io</artifactId> | ||
| <scope>provided</scope> |
Contributor
There was a problem hiding this comment.
Is there a reason to explicitly specify the provided deps? (I'm thinking they won't be packaged anyway)
Contributor
Author
There was a problem hiding this comment.
The dependency:analyze goal (via the outputXML property) suggested the provided scope.
gianm
approved these changes
Jul 24, 2019
| - NAME="analyze dependencies" | ||
| install: MAVEN_OPTS='-Xmx3000m' mvn install -q -ff -DskipTests -B | ||
| script: MAVEN_OPTS='-Xmx3000m' mvn dependency:analyze -DoutputXML=true -DignoreNonCompile=true -DfailOnWarning=true | ||
| after_failure: |
Contributor
Author
|
The SS_SHOULD_BE_STATIC failures for the "strict compilation" job are the same as #8135. |
…ncy-analyze-warnings
…ncy-analyze-warnings
ccaominh
added a commit
to ccaominh/druid
that referenced
this pull request
Jul 29, 2019
This reverts commit 5dd0d8e.
fjy
pushed a commit
that referenced
this pull request
Jul 29, 2019
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the maven dependency plugin to the latest version and fix all warnings for unused declared and used undeclared dependencies in the compile scope (command:
mvn dependency:analyze -DoutputXML=true -DignoreNonCompile=true -DfailOnWarning=true). Added new travis job to add the check to CI. Also fixed some source code files to use the correct packages for their imports.This PR has: