Skip to content

Revert "Fix dependency analyze warnings (#8128)"#8189

Merged
fjy merged 1 commit intoapache:masterfrom
ccaominh:revert-fix-maven-dependency-analyze-warnings
Jul 29, 2019
Merged

Revert "Fix dependency analyze warnings (#8128)"#8189
fjy merged 1 commit intoapache:masterfrom
ccaominh:revert-fix-maven-dependency-analyze-warnings

Conversation

@ccaominh
Copy link
Copy Markdown
Contributor

This reverts commit 5dd0d8e, as the earlier change has incorrect runtime dependencies.

@jihoonson
Copy link
Copy Markdown
Contributor

@ccaominh thanks for raising this PR. +1 after CI.

I'm seeing the below error with druid-s3-extensions.

SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
Could not load Logmanager "org.apache.logging.log4j.jul.LogManager"
java.lang.ClassNotFoundException: org.apache.logging.log4j.jul.LogManager
        at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
        at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
        at java.util.logging.LogManager$1.run(LogManager.java:195)
        at java.util.logging.LogManager$1.run(LogManager.java:181)
        at java.security.AccessController.doPrivileged(Native Method)
        at java.util.logging.LogManager.<clinit>(LogManager.java:181)
        at java.util.logging.Logger.demandLogger(Logger.java:448)
        at java.util.logging.Logger.getLogger(Logger.java:502)
        at com.google.inject.internal.util.Stopwatch.<clinit>(Stopwatch.java:27)
        at com.google.inject.internal.InternalInjectorCreator.<init>(InternalInjectorCreator.java:61)
        at com.google.inject.Guice.createInjector(Guice.java:96)
        at com.google.inject.Guice.createInjector(Guice.java:73)
        at org.apache.druid.guice.GuiceInjectors.makeStartupInjector(GuiceInjectors.java:56)
        at org.apache.druid.cli.Main.main(Main.java:95)
Jul 28, 2019 9:05:32 PM org.hibernate.validator.internal.util.Version <clinit>
INFO: HV000001: Hibernate Validator 5.1.3.Final
Exception in thread "main" com.google.common.util.concurrent.ExecutionError: java.lang.NoClassDefFoundError: com/amazonaws/ClientConfiguration
        at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2199)
        at com.google.common.cache.LocalCache.get(LocalCache.java:3934)
        at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:3938)
        at com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4821)
        at com.google.common.cache.LocalCache$LocalLoadingCache.getUnchecked(LocalCache.java:4827)
        at com.google.inject.internal.FailableCache.get(FailableCache.java:48)
        at com.google.inject.internal.MembersInjectorStore.get(MembersInjectorStore.java:68)
        at com.google.inject.internal.InjectorImpl.getMembersInjector(InjectorImpl.java:993)
        at com.google.inject.internal.InjectorImpl.getMembersInjector(InjectorImpl.java:1000)
        at com.google.inject.internal.InjectorImpl.injectMembers(InjectorImpl.java:986)
        at org.apache.druid.initialization.Initialization$ModuleList.addModule(Initialization.java:450)
        at org.apache.druid.initialization.Initialization.makeInjectorWithModules(Initialization.java:416)
        at org.apache.druid.cli.GuiceRunnable.makeInjector(GuiceRunnable.java:68)
        at org.apache.druid.cli.ServerRunnable.run(ServerRunnable.java:56)
        at org.apache.druid.cli.Main.main(Main.java:112)
Caused by: java.lang.NoClassDefFoundError: com/amazonaws/ClientConfiguration
        at java.lang.Class.getDeclaredMethods0(Native Method)
        at java.lang.Class.privateGetDeclaredMethods(Class.java:2701)
        at java.lang.Class.getDeclaredMethods(Class.java:1975)
        at com.google.inject.spi.InjectionPoint.getInjectionPoints(InjectionPoint.java:688)
        at com.google.inject.spi.InjectionPoint.forInstanceMethodsAndFields(InjectionPoint.java:380)
        at com.google.inject.internal.MembersInjectorStore.createWithListeners(MembersInjectorStore.java:93)
        at com.google.inject.internal.MembersInjectorStore.access$000(MembersInjectorStore.java:37)
        at com.google.inject.internal.MembersInjectorStore$1.create(MembersInjectorStore.java:45)
        at com.google.inject.internal.MembersInjectorStore$1.create(MembersInjectorStore.java:42)
        at com.google.inject.internal.FailableCache$1.load(FailableCache.java:37)
        at com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3524)
        at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2317)
        at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2280)
        at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2195)
        ... 14 more
Caused by: java.lang.ClassNotFoundException: com.amazonaws.ClientConfiguration
        at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
        ... 28 more

@fjy fjy merged commit ab71a2e into apache:master Jul 29, 2019
@ccaominh ccaominh deleted the revert-fix-maven-dependency-analyze-warnings branch July 30, 2019 22:26
@clintropolis clintropolis added this to the 0.16.0 milestone Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants