Skip to content

Add grade shield#8344

Merged
asdf2014 merged 1 commit intoapache:masterfrom
asdf2014:add_grade_shield
Aug 21, 2019
Merged

Add grade shield#8344
asdf2014 merged 1 commit intoapache:masterfrom
asdf2014:add_grade_shield

Conversation

@asdf2014
Copy link
Copy Markdown
Member

@asdf2014 asdf2014 commented Aug 20, 2019 •
edited
Loading

Description

Add grade shield Language grade: Java, more details: #8337 (comment)

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths.
  • added integration tests.
  • been tested in a test Druid cluster.

Fokko
Fokko approved these changes Aug 20, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

ccaominh
ccaominh approved these changes Aug 20, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@ccaominh ccaominh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@gianm
Copy link
Copy Markdown
Contributor

gianm commented Aug 20, 2019

@asdf2014, apologies for introducing conflicts by merging #8303. Could you please fix them up -- afterwards this looks good to go.

@asdf2014 asdf2014 merged commit c4db836 into apache:master Aug 21, 2019
@asdf2014 asdf2014 deleted the add_grade_shield branch August 21, 2019 04:20
@clintropolis clintropolis added this to the 0.16.0 milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fokko Fokko Fokko approved these changes

@clintropolis clintropolis clintropolis approved these changes

@ccaominh ccaominh ccaominh approved these changes

Assignees

No one assigned

Labels

Area - Documentation

Projects

None yet

Milestone

0.16.0

Development

Successfully merging this pull request may close these issues.

5 participants

@asdf2014 @gianm @Fokko @clintropolis @ccaominh