Merged
Conversation
Code coverage was disabled via apache#3122 due to an issue with cobertura in Travis CI. Switch code coverage tool from cobertura to jacoco to avoid issue and re-enable coveralls for Travis CI.
090818d to
f8a2a62
Compare
| <!-- Ignore generated code --> | ||
| <exclude>org/apache/druid/math/expr/antlr/Expr*</exclude> <!-- core --> | ||
| <exclude>org/apache/druid/**/generated/*Benchmark*</exclude> <!-- benchmarks --> | ||
| <exclude>org/apache/druid/data/input/influx/InfluxLineProtocol*</exclude> <!-- extensions-contrib/influx-extensions --> |
Member
There was a problem hiding this comment.
I wonder if maybe we should ignore all of benchmarks instead of just the generated stuff, and also integration-tests since neither contain production code?
Contributor
Author
There was a problem hiding this comment.
Added benchmarks and integration-tests to the exclusions
Member
Contributor
|
In #8359 coverage build failed due to drop by 0.09% (report says coverage of files not touched in the PR dropped) @clintropolis @gianm |
Contributor
Author
|
@himanshug I'm hoping #8374 will fix the issue with the fluctuating coverage reports |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #6009.
Description
Code coverage was disabled via #3122 due to an issue with
cobertura in Travis CI. Switch code coverage tool from cobertura to
jacoco to avoid issue and re-enable coveralls for Travis CI.
This PR has: