Make running test in Intellij work with JaCoCo#8526
Merged
fjy merged 2 commits intoapache:masterfrom Sep 14, 2019
Merged
Conversation
After the jacoco-maven-plugin was added, running test in IntelliJ fails
with the error "Could not find or load main class @{jacocoArgLine}".
Add a default IntelliJ configuration file so that running tests in the
IDE works with the jacoco-maven-plugin configuration and the
out-of-the-box developer experience is better. Other solutions described
in https://stackoverflow.com/q/24115142 (e.g., setting an empty
"jacocoArgLine" maven property) did not work.
Contributor
Author
|
|
leventov
reviewed
Sep 13, 2019
Member
leventov
left a comment
There was a problem hiding this comment.
Thanks! I confirm that it works.
| <component name="MavenProjectSettings"> | ||
| <option name="testRunningSettings"> | ||
| <MavenTestRunningSettings> | ||
| <option name="passArgLine" value="false" /> |
Member
There was a problem hiding this comment.
Could you please add line
<!-- See https://github.com/apache/incubator-druid/issues/8524 -->
Before this line.
Member
There was a problem hiding this comment.
Or better reference https://github.com/apache/incubator-druid/pull/8526 (i. e. this PR) because it has extra details in the description.
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jan 2, 2020
* Make running test in Intellij work with JaCoCo
After the jacoco-maven-plugin was added, running test in IntelliJ fails
with the error "Could not find or load main class @{jacocoArgLine}".
Add a default IntelliJ configuration file so that running tests in the
IDE works with the jacoco-maven-plugin configuration and the
out-of-the-box developer experience is better. Other solutions described
in https://stackoverflow.com/q/24115142 (e.g., setting an empty
"jacocoArgLine" maven property) did not work.
* Add comment with link to PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8524.
Description
After the jacoco-maven-plugin was added, running test in IntelliJ fails with the error
Could not find or load main class @{jacocoArgLine}. Add a default IntelliJ configuration file so that running tests in the IDE works with the jacoco-maven-plugin configuration and the out-of-the-box developer experience is better. Other solutions described in https://stackoverflow.com/q/24115142 (e.g., setting an empty "jacocoArgLine" maven property) did not work.This PR has: