Skip to content

Eclipse Java Compiler issues fixed#8811

Closed
sbespalov wants to merge 1 commit intoapache:masterfrom
sbespalov:ejc-fix
Closed

Eclipse Java Compiler issues fixed#8811
sbespalov wants to merge 1 commit intoapache:masterfrom
sbespalov:ejc-fix

Conversation

@sbespalov
Copy link
Copy Markdown

@sbespalov sbespalov commented Nov 2, 2019

Description

This PR fixes Eclipse Java Compiller (ejc) issues:

  • Generic type determination fixed by specifying the type parameter
  • this reference within closure anonymous class as parameter of super constructor invocation fixed by replacing the anonymous function with dedicated class

Below is the list of classes with EJC errors that was fixed:

  • CachingClusteredClientBenchmark

Cannot infer type arguments for FluentQueryRunnerBuilder<>

  • AsyncQueryForwardingServlet

The method makeRequestMetrics(GenericQueryMetricsFactory, QueryToolChest<T,Query>, Query, String) in the type DruidMetrics is not applicable for the arguments (GenericQueryMetricsFactory, QueryToolChest<capture#1-of ?,capture#2-of ?>, Query, String)

  • DruidCoordinator

Cannot refer to 'this' nor 'super' while explicitly invoking a constructor

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths.
  • added integration tests.
  • been tested in a test Druid cluster.

Key changed/added classes in this PR
  • DruidCoordinatorSegmentReplicantLookupConsumer

@sbespalov sbespalov force-pushed the ejc-fix branch 4 times, most recently from e8db1a6 to 5c5af0d Compare November 2, 2019 16:07
@sbespalov
Copy link
Copy Markdown
Author

Closed because of failed integration tests. New #8818 opened.

@sbespalov sbespalov closed this Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant