Skip to content

Eclipse Java Compiler issues fixed#8818

Closed
sbespalov wants to merge 1 commit intoapache:masterfrom
sbespalov:ejc-issuses-fix
Closed

Eclipse Java Compiler issues fixed#8818
sbespalov wants to merge 1 commit intoapache:masterfrom
sbespalov:ejc-issuses-fix

Conversation

@sbespalov
Copy link
Copy Markdown

Description

This PR fixes Eclipse Java Compiller (ejc) issues:

  • Generic type determination fixed by specifying the type parameter
  • this reference within closure anonymous class as parameter of super constructor invocation fixed by replacing the anonymous function with dedicated class

Below is the list of classes with EJC errors that was fixed:

  • CachingClusteredClientBenchmark

Cannot infer type arguments for FluentQueryRunnerBuilder<>

  • AsyncQueryForwardingServlet

The method makeRequestMetrics(GenericQueryMetricsFactory, QueryToolChest<T,Query>, Query, String) in the type DruidMetrics is not applicable for the arguments (GenericQueryMetricsFactory, QueryToolChest<capture#1-of ?,capture#2-of ?>, Query, String)

  • DruidCoordinator

Cannot refer to 'this' nor 'super' while explicitly invoking a constructor

Key changed/added classes in this PR
  • DruidCoordinatorSegmentReplicantLookupConsumer

@sbespalov sbespalov mentioned this pull request Nov 3, 2019
8 tasks
@vogievetsky
Copy link
Copy Markdown
Contributor

I think this needs to merge in master to pass TeamCity

@sbespalov
Copy link
Copy Markdown
Author

it's seems passing now, thanks @vogievetsky

@sbespalov
Copy link
Copy Markdown
Author

@vogievetsky can you please review?

@stale
Copy link
Copy Markdown

stale Bot commented Mar 11, 2020

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.

@stale stale Bot added the stale label Mar 11, 2020
@sbespalov
Copy link
Copy Markdown
Author

sbespalov commented Mar 11, 2020

relevant, waiting for review

@stale
Copy link
Copy Markdown

stale Bot commented Mar 11, 2020

This issue is no longer marked as stale.

@stale stale Bot removed the stale label Mar 11, 2020
@jihoonson
Copy link
Copy Markdown
Contributor

Hi @sbespalov, sorry for the delayed review. Would you please resolve the conflicts?

this reference within closure anonymous class as parameter of super constructor invocation fixed by replacing the anonymous function with dedicated class

There has been some refactoring around the coordinator (#7306) and I believe this issue was fixed in that PR.

@stale
Copy link
Copy Markdown

stale Bot commented May 25, 2020

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.

@stale stale Bot added the stale label May 25, 2020
@stale
Copy link
Copy Markdown

stale Bot commented Jun 22, 2020

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@stale stale Bot closed this Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants