Eclipse Java Compiler issues fixed#8818
Conversation
|
I think this needs to merge in master to pass TeamCity |
82041b8 to
5b5a90d
Compare
|
it's seems passing now, thanks @vogievetsky |
5b5a90d to
fd261e1
Compare
|
@vogievetsky can you please review? |
fd261e1 to
24bda9d
Compare
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions. |
|
relevant, waiting for review |
|
This issue is no longer marked as stale. |
|
Hi @sbespalov, sorry for the delayed review. Would you please resolve the conflicts?
There has been some refactoring around the coordinator (#7306) and I believe this issue was fixed in that PR. |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions. |
|
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Description
This PR fixes Eclipse Java Compiller (ejc) issues:
thisreference within closure anonymous class as parameter of super constructor invocation fixed by replacing the anonymous function with dedicated classBelow is the list of classes with EJC errors that was fixed:
CachingClusteredClientBenchmarkAsyncQueryForwardingServletDruidCoordinatorKey changed/added classes in this PR
DruidCoordinatorSegmentReplicantLookupConsumer