Skip to content

modify multi-value automatic expression transformation#8957

Merged
jon-wei merged 1 commit intoapache:masterfrom
clintropolis:multi-val-no-cartesian-on-dupe-inputs
Dec 10, 2019
Merged

modify multi-value automatic expression transformation#8957
jon-wei merged 1 commit intoapache:masterfrom
clintropolis:multi-val-no-cartesian-on-dupe-inputs

Conversation

@clintropolis
Copy link
Copy Markdown
Member

Description

This PR modifies behavior of multi-value expression automatic transformations to not treat re-use of the same input as a candidate for cartesian mapping, functionally reverting #8019 pending the outcome of the discussion in #8947.


This PR has:

  • been self-reviewed.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths.

…-use of the same input as a candidate for cartesian mapping
@jon-wei jon-wei merged commit 4327892 into apache:master Dec 10, 2019
@jon-wei jon-wei added this to the 0.17.0 milestone Dec 17, 2019
@jon-wei jon-wei mentioned this pull request Dec 28, 2019
@clintropolis clintropolis deleted the multi-val-no-cartesian-on-dupe-inputs branch April 8, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants