allow optimization of single multi-value column input expr with repeated identifier#9425
Merged
gianm merged 2 commits intoapache:masterfrom Mar 6, 2020
Merged
Conversation
gianm
approved these changes
Feb 27, 2020
Contributor
gianm
left a comment
gianm
left a comment
There was a problem hiding this comment.
LGTM.
Can you think of a way to add a test? (The results don't change, we were just missing a performance optimization. We don't have a perf test framework yet, but even without one, any ideas?)
clintropolis
force-pushed
the
single-string-multi-val-expr-fix
branch
from
6db5d15 to
9453c5f
Compare
Member
Author
It is pretty ugly, but I added a test to confirm that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9414.
Description
An oversight from #8957, I forgot to remove this check, which was preventing single multi-valued column input expressions from using an optimized single column expression selector.
This PR has:
Key changed/added classes in this PR
ExpressionSelectors