Fix equalsAndHashCode in ClientCompactQueryTuningConfig#9035
Merged
jon-wei merged 3 commits intoapache:masterfrom Dec 16, 2019
Merged
Fix equalsAndHashCode in ClientCompactQueryTuningConfig#9035jon-wei merged 3 commits intoapache:masterfrom
jon-wei merged 3 commits intoapache:masterfrom
Conversation
This change introduces a dependency to EqualsVerifier for the test scope. The dependency is licensed under Apache 2. The library makes it trivial to add equals and hashCode checks to prevent bugs like this from happening in the future
Contributor
Author
|
Licenses not added to the yaml file since the dependency is a test only dependency. It's licensed under apache 2 though - https://github.com/jqno/equalsverifier/blob/master/LICENSE.md |
gianm
reviewed
Dec 16, 2019
Contributor
gianm
left a comment
gianm
left a comment
There was a problem hiding this comment.
LGTM other than naming comment
| public class ClientCompactQueryTuningConfigTest | ||
| { | ||
| @Test | ||
| public void test_equalsContract() |
Contributor
There was a problem hiding this comment.
testEqualsContract would be more typical Druid style.
gianm
approved these changes
Dec 16, 2019
suneet-s
added a commit
to suneet-s/druid
that referenced
this pull request
Dec 16, 2019
* Fix equalsAndHashCode in ClientCompactQueryTuningConfig This change introduces a dependency to EqualsVerifier for the test scope. The dependency is licensed under Apache 2. The library makes it trivial to add equals and hashCode checks to prevent bugs like this from happening in the future * fix checkstyle * fix test name
jon-wei
pushed a commit
that referenced
this pull request
Dec 17, 2019
* Fix equalsAndHashCode in ClientCompactQueryTuningConfig This change introduces a dependency to EqualsVerifier for the test scope. The dependency is licensed under Apache 2. The library makes it trivial to add equals and hashCode checks to prevent bugs like this from happening in the future * fix checkstyle * fix test name
suneet-s
added a commit
to implydata/druid-public
that referenced
this pull request
Dec 17, 2019
…apache#9051) * Fix equalsAndHashCode in ClientCompactQueryTuningConfig This change introduces a dependency to EqualsVerifier for the test scope. The dependency is licensed under Apache 2. The library makes it trivial to add equals and hashCode checks to prevent bugs like this from happening in the future * fix checkstyle * fix test name
suneet-s
added a commit
to implydata/druid-public
that referenced
this pull request
Dec 18, 2019
…apache#9051) (#22) This change introduces a dependency to EqualsVerifier for the test scope. The dependency is licensed under Apache 2. The library makes it trivial to add equals and hashCode checks to prevent bugs like this from happening in the future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8866.
Description
This change introduces a dependency to EqualsVerifier for the test scope.
The dependency is licensed under Apache 2. The library makes it trivial
to add equals and hashCode checks to prevent bugs like this from happening
in the future
This PR has: