[0.17.0-incubating] Fix equalsAndHashCode in ClientCompactQueryTuningConfig (#9035)#9051
Merged
jon-wei merged 1 commit intoapache:0.17.0-incubatingfrom Dec 17, 2019
Conversation
suneet-s
force-pushed
the
backport/0.17.0-incubating/pr-9035
branch
from
3fb27ec to
ea7c167
Compare
* Fix equalsAndHashCode in ClientCompactQueryTuningConfig This change introduces a dependency to EqualsVerifier for the test scope. The dependency is licensed under Apache 2. The library makes it trivial to add equals and hashCode checks to prevent bugs like this from happening in the future * fix checkstyle * fix test name
suneet-s
force-pushed
the
backport/0.17.0-incubating/pr-9035
branch
from
ea7c167 to
3752285
Compare
jon-wei
approved these changes
Dec 17, 2019
suneet-s
added a commit
to implydata/druid-public
that referenced
this pull request
Dec 17, 2019
…apache#9051) * Fix equalsAndHashCode in ClientCompactQueryTuningConfig This change introduces a dependency to EqualsVerifier for the test scope. The dependency is licensed under Apache 2. The library makes it trivial to add equals and hashCode checks to prevent bugs like this from happening in the future * fix checkstyle * fix test name
suneet-s
added a commit
to implydata/druid-public
that referenced
this pull request
Dec 18, 2019
…apache#9051) (#22) This change introduces a dependency to EqualsVerifier for the test scope. The dependency is licensed under Apache 2. The library makes it trivial to add equals and hashCode checks to prevent bugs like this from happening in the future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 0.17.0-incubating: