Use auto-form for add an edit lookups#9587
Merged
vogievetsky merged 13 commits intoapache:masterfrom Apr 8, 2020
Merged
Conversation
|
This pull request introduces 1 alert when merging 4c3385b into fa5da66 - view on LGTM.com new alerts:
|
vogievetsky
reviewed
Apr 7, 2020
| { | ||
| name: 'extractionNamespace.pollPeriod', | ||
| type: 'string', | ||
| label: 'Poll Period', |
vogievetsky
reviewed
Apr 7, 2020
| (lookupSpec.type === 'cachedNamespace' && lookupSpec.extractionNamespace === undefined); | ||
|
|
||
| if (!disableSubmit && lookupSpec.type === 'cachedNamespace' && lookupSpec.extractionNamespace) { | ||
| const namespaceParseSpec = lookupSpec.extractionNamespace.namespaceParseSpec; |
Contributor
There was a problem hiding this comment.
can you extract his whole check into a function please?
vogievetsky
reviewed
Apr 8, 2020
| name: 'extractionNamespace.connectorConfig.user', | ||
| type: 'string', | ||
| label: 'User', | ||
| info: 'Defines the user too be used by the connector config', |
| name: 'extractionNamespace.connectorConfig.password', | ||
| type: 'string', | ||
| label: 'Password', | ||
| info: 'Defines the password too be used by the connector config', |
| <br /> | ||
| SELECT keyColumn, valueColumn, tsColumn? FROM namespace.<strong>table</strong> WHERE | ||
| filter | ||
| </p> |
Contributor
There was a problem hiding this comment.
instead of <br> it is better to use multiple <p>s like so:
<>
<p>
The table which contains the key value pairs. This will become the table value in the SQL
query:
</p>
<p>
SELECT keyColumn, valueColumn, tsColumn? FROM namespace.<strong>table</strong> WHERE
filter
</p>
</>
| { | ||
| name: 'extractionNamespace.filter', | ||
| type: 'string', | ||
| label: 'Filter', |
Contributor
There was a problem hiding this comment.
add a placeholder of '(optional)' that is the convention that I've been using in several places.
Contributor
|
Thank you for responding to all the feedback! |
JulianJaffePinterest
pushed a commit
to JulianJaffePinterest/druid
that referenced
this pull request
Jun 12, 2020
* use auto form * jest -u * fix unreachable statment * complete the owl * jest -u * remove changes to query-view * fix permissions * add test, fix info * add cool highlights * fix formatting * fix capitalization * add optional placeholder * add space
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lookup 'spec json input has been replace with an auto form the capture the type and the map for the auto form. You cannot submit a lookup unless it has a type and that the map is an object composed of key value pairs where the value is of type string.