Skip to content

Use auto-form for add an edit lookups #9587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vogievetsky merged 13 commits into from
Apr 8, 2020
Merged

Use auto-form for add an edit lookups #9587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0038d0a
use auto form
mcbrewster Mar 30, 2020
4c3385b
jest -u
mcbrewster Mar 30, 2020
9a6d603
fix unreachable statment
mcbrewster Mar 30, 2020
0b068c3
complete the owl
mcbrewster Apr 2, 2020
56a5c86
jest -u
mcbrewster Apr 6, 2020
1ac504d
remove changes to query-view
mcbrewster Apr 6, 2020
7473a61
fix permissions
mcbrewster Apr 7, 2020
511fe04
add test, fix info
mcbrewster Apr 7, 2020
3a2582b
add cool highlights
mcbrewster Apr 7, 2020
85b75af
fix formatting
mcbrewster Apr 8, 2020
8e5e64c
fix capitalization
mcbrewster Apr 8, 2020
da36e6a
add optional placeholder
mcbrewster Apr 8, 2020
50778c0
add space
mcbrewster Apr 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
252 changes: 160 additions & 92 deletions web-console/src/dialogs/lookup-edit-dialog/__snapshots__/lookup-edit-dialog.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ exports[`lookup edit dialog matches snapshot 1`] = `
<label
class="bp3-label"
>
Name:
Name

<span
class="bp3-text-muted"
Expand Down Expand Up @@ -86,7 +86,7 @@ exports[`lookup edit dialog matches snapshot 1`] = `
<label
class="bp3-label"
>
Tier:
Tier

<span
class="bp3-text-muted"
Expand Down Expand Up @@ -178,7 +178,7 @@ exports[`lookup edit dialog matches snapshot 1`] = `
<label
class="bp3-label"
>
Version:
Version

<span
class="bp3-text-muted"
Expand Down Expand Up @@ -215,107 +215,177 @@ exports[`lookup edit dialog matches snapshot 1`] = `
</div>
</div>
<div
class="bp3-form-group lookup-label"
class="auto-form"
>
<label
class="bp3-label"
>
Spec:

<span
class="bp3-text-muted"
/>
</label>
<div
class="bp3-form-content"
/>
</div>
<div
class=" ace_editor ace-tm lookup-edit-dialog-textarea"
id="brace-editor"
style="width: auto; height: 40vh;"
>
<textarea
autocapitalize="off"
autocorrect="off"
class="ace_text-input"
spellcheck="false"
style="opacity: 0;"
wrap="off"
/>
<div
aria-hidden="true"
class="ace_gutter"
style="display: none;"
>
<div
class="ace_layer ace_gutter-layer ace_folding-enabled"
/>
<div
class="ace_gutter-active-line"
/>
</div>
<div
class="ace_scroller"
class="bp3-form-group form-group-with-info"
>
<div
class="ace_content"
<label
class="bp3-label"
>
<div
class="ace_layer ace_print-margin-layer"
>
<div
class="ace_print-margin"
style="left: 4px; visibility: hidden;"
/>
</div>
<div
class="ace_layer ace_marker-layer"
/>
<div
class="ace_layer ace_text-layer"
style="padding: 0px 4px;"
/>
<div
class="ace_layer ace_marker-layer"
Type

<span
class="bp3-text-muted"
/>
</label>
<div
class="bp3-form-content"
>
<div
class="ace_layer ace_cursor-layer ace_hidden-cursors"
class="bp3-input-group suggestible-input"
>
<div
class="ace_cursor"
<input
class="bp3-input"
placeholder=""
style="padding-right: 0px;"
suggestions="map,cachedNamespace"
type="text"
value="map"
/>
<span
class="bp3-input-action"
>
<span
class="bp3-popover-wrapper"
>
<span
class="bp3-popover-target"
>
<button
class="bp3-button bp3-minimal"
type="button"
>
<span
class="bp3-icon bp3-icon-caret-down"
icon="caret-down"
>
<svg
data-icon="caret-down"
height="16"
viewBox="0 0 16 16"
width="16"
>
<desc>
caret-down
</desc>
<path
d="M12 6.5c0-.28-.22-.5-.5-.5h-7a.495.495 0 00-.37.83l3.5 4c.09.1.22.17.37.17s.28-.07.37-.17l3.5-4c.08-.09.13-.2.13-.33z"
fill-rule="evenodd"
/>
</svg>
</span>
</button>
</span>
</span>
</span>
</div>
</div>
</div>
<div
class="ace_scrollbar ace_scrollbar-v"
style="display: none; width: 20px;"
>
<div
class="ace_scrollbar-inner"
style="width: 20px;"
/>
</div>
<div
class="ace_scrollbar ace_scrollbar-h"
style="display: none; height: 20px;"
class="bp3-form-group form-group-with-info"
>
<label
class="bp3-label"
>
Map

<span
class="bp3-text-muted"
/>
</label>
<div
class="ace_scrollbar-inner"
style="height: 20px;"
/>
</div>
<div
style="height: auto; width: auto; top: 0px; left: 0px; visibility: hidden; position: absolute; white-space: pre; overflow: hidden;"
>
<div
style="height: auto; width: auto; top: 0px; left: 0px; visibility: hidden; position: absolute; white-space: pre; overflow: visible;"
/>
<div
style="height: auto; width: auto; top: 0px; left: 0px; visibility: hidden; position: absolute; white-space: pre; overflow: visible;"
class="bp3-form-content"
>
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
<div
class=" ace_editor ace-tm json-input"
id="brace-editor"
style="width: 100%; height: 8vh;"
>
<textarea
autocapitalize="off"
autocorrect="off"
class="ace_text-input"
spellcheck="false"
style="opacity: 0;"
wrap="off"
/>
<div
aria-hidden="true"
class="ace_gutter"
style="display: none;"
>
<div
class="ace_layer ace_gutter-layer ace_folding-enabled"
/>
<div
class="ace_gutter-active-line"
/>
</div>
<div
class="ace_scroller"
>
<div
class="ace_content"
>
<div
class="ace_layer ace_print-margin-layer"
>
<div
class="ace_print-margin"
style="left: 4px; visibility: hidden;"
/>
</div>
<div
class="ace_layer ace_marker-layer"
/>
<div
class="ace_layer ace_text-layer"
style="padding: 0px 4px;"
/>
<div
class="ace_layer ace_marker-layer"
/>
<div
class="ace_layer ace_cursor-layer ace_hidden-cursors"
>
<div
class="ace_cursor"
/>
</div>
</div>
</div>
<div
class="ace_scrollbar ace_scrollbar-v"
style="display: none; width: 20px;"
>
<div
class="ace_scrollbar-inner"
style="width: 20px;"
/>
</div>
<div
class="ace_scrollbar ace_scrollbar-h"
style="display: none; height: 20px;"
>
<div
class="ace_scrollbar-inner"
style="height: 20px;"
/>
</div>
<div
style="height: auto; width: auto; top: 0px; left: 0px; visibility: hidden; position: absolute; white-space: pre; overflow: hidden;"
>
<div
style="height: auto; width: auto; top: 0px; left: 0px; visibility: hidden; position: absolute; white-space: pre; overflow: visible;"
/>
<div
style="height: auto; width: auto; top: 0px; left: 0px; visibility: hidden; position: absolute; white-space: pre; overflow: visible;"
>
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
</div>
</div>
</div>
</div>
</div>
</div>
Expand All @@ -336,9 +406,7 @@ exports[`lookup edit dialog matches snapshot 1`] = `
</span>
</button>
<button
class="bp3-button bp3-disabled bp3-intent-primary"
disabled=""
tabindex="-1"
class="bp3-button bp3-intent-primary"
type="button"
>
<span
Expand Down
4 changes: 2 additions & 2 deletions web-console/src/dialogs/lookup-edit-dialog/lookup-edit-dialog.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
width: 600px;
}

.ace_editor {
margin: 0px 20px 10px;
.auto-form {
margin: 5px 20px 10px;
}

.lookup-label {
Expand Down
Loading