Potential RpcServiceContext contamination in Dubbo 3

[wu-sheng]

• I have searched the issues of this repository and believe that this is not a duplicate.

Environment

• Dubbo version: 3.x
• Operating System version: xxx
• Java version: xxx

Steps to reproduce this issue

The whole discussion context could be found in this SkyWalking's bug report, apache/skywalking#8525
According to the discussion, when a service acts as a provider and consumer at the same time, serviceContext.isConsumerSide(); always returns true even it is already in the customer calling context.

Pls. provide [GitHub address] to reproduce this issue.

Expected Behavior

serviceContext.isConsumerSide(); works as expected, even it is in a provider->internal logic->consumer in-process scenario.

Actual Behavior

If there is an exception, please attach the exception trace:

Just put your stack trace here!

[beiwei30]

@chickenlj @AlbumenJ

[chickenlj]

We will try to figure out this issue in the next major release

[wu-sheng]

@honganan Let's wait for a solution here, no matter this should be fixed on skywalking or dubbo.

[honganan]

@honganan Let's wait for a solution here, no matter this should be fixed on skywalking or dubbo.

ok

[wu-sheng]

Any update from Dubbo community?

[wu-sheng]

We did full research on apache/skywalking-java#110, which is ready to merge soon.
I want to update the Dubbo community, this is a bug for sure. We are using a bypass to check whether it is a provider side or a consumer side, and avoid using the native context's status only.

But this would affect other users too. It is better Dubbo could fix this. SkyWalking community will keep in this bypass solution, to make sure all existing previous releases(before your fix) could work well with our agent.

[AlbumenJ]

Will be fix in #9740

[honganan]

Will be fix in #9740

That's nice! After that we will change to invoking Dubbo api directly.