Skip to content

[3.0] Fix isConsumerSide not work in sub invoke#9740

Merged
chickenlj merged 1 commit intoapache:3.0from
AlbumenJ:0307_fix_side
Mar 14, 2022
Merged

[3.0] Fix isConsumerSide not work in sub invoke#9740
chickenlj merged 1 commit intoapache:3.0from
AlbumenJ:0307_fix_side

Conversation

@AlbumenJ
Copy link
Copy Markdown
Member

@AlbumenJ AlbumenJ commented Mar 7, 2022

What is the purpose of the change

Fix #9666
A -> B -> C
When B invoke C, url from TL should be changed to cluster invoker's url.

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 7, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.73%. Comparing base (b7b4993) to head (09d5b7b).
⚠️ Report is 276 commits behind head on 3.0.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.0    #9740      +/-   ##
============================================
+ Coverage     65.70%   65.73%   +0.02%     
- Complexity      296      297       +1     
============================================
  Files          1206     1206              
  Lines         52322    52323       +1     
  Branches       7942     7942              
============================================
+ Hits          34378    34394      +16     
+ Misses        14212    14199      -13     
+ Partials       3732     3730       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chickenlj chickenlj merged commit ae34adb into apache:3.0 Mar 14, 2022
guohao pushed a commit to guohao/dubbo that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potential RpcServiceContext contamination in Dubbo 3

3 participants