Skip to content

feat: add stackStrategy docs#255

Merged
pissang merged 4 commits into
apache:devfrom
villebro:villebro/stackStrategy
May 29, 2022
Merged

feat: add stackStrategy docs#255
pissang merged 4 commits into
apache:devfrom
villebro:villebro/stackStrategy

Conversation

@villebro
Copy link
Copy Markdown
Member

@villebro villebro commented May 23, 2022

Docs for the stackStrategy feature proposed in apache/echarts#17086

@villebro villebro mentioned this pull request May 23, 2022
Merged
6 tasks
@villebro villebro changed the title feat: add stackStrategy docs [WIP] feat: add stackStrategy docs May 23, 2022
@villebro villebro marked this pull request as draft May 23, 2022 10:58
@villebro villebro changed the title [WIP] feat: add stackStrategy docs feat: add stackStrategy docs May 23, 2022
@villebro villebro requested a review from pissang May 27, 2022 11:45
@villebro villebro marked this pull request as ready for review May 27, 2022 11:45
@villebro
Copy link
Copy Markdown
Member Author

villebro commented May 28, 2022

Ping @pissang @Ovilia @susiwen8 is this PR ok to be merged now that the feature PR has been merged?

@villebro villebro requested review from Ovilia and susiwen8 May 28, 2022 07:47
@susiwen8
Copy link
Copy Markdown
Contributor

susiwen8 commented May 28, 2022 •
edited
Loading

Could you add version? Since this will be introduced in 5.3.3
@pissang Are we prepare to land this feature in 5.3.3?

@villebro
Copy link
Copy Markdown
Member Author

villebro commented May 28, 2022

Could you add version? Since this will be introduced in 5.3.3 @pissang Are we prepare to land this feature in 5.3.3?

Thanks @susiwen8 - I added the version here: d4d6baa

@villebro villebro force-pushed the villebro/stackStrategy branch from 0bdb850 to b93c936 Compare May 28, 2022 13:08
@villebro villebro force-pushed the villebro/stackStrategy branch from b93c936 to 9195266 Compare May 28, 2022 13:10
@susiwen8
Copy link
Copy Markdown
Contributor

susiwen8 commented May 29, 2022

Since 5.3.3 isn't published, so it better to merge this PR after release

@pissang pissang changed the base branch from master to dev May 29, 2022 09:11
@pissang pissang changed the base branch from dev to master May 29, 2022 09:12
@pissang pissang changed the base branch from master to dev May 29, 2022 09:12
@pissang pissang changed the base branch from dev to master May 29, 2022 09:13
@pissang pissang changed the base branch from master to dev May 29, 2022 09:13
@pissang
Copy link
Copy Markdown
Contributor

pissang commented May 29, 2022

Added Chinese translation and merged to dev branch

@pissang pissang merged commit 544e1f9 into apache:dev May 29, 2022
plainheart added a commit that referenced this pull request Jun 14, 2022
@plainheart
tweak #255
50c684c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pissang pissang Awaiting requested review from pissang

@Ovilia Ovilia Awaiting requested review from Ovilia

@susiwen8 susiwen8 Awaiting requested review from susiwen8

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@villebro @susiwen8 @pissang