feat: add new stacking strategies#17086
Merged
Merged
Conversation
|
Thanks for your contribution! The pull request is marked to be |
Member
Author
|
Docs for the proposed feature: apache/echarts-doc#255 |
Member
Author
|
@pissang let me know if you feel this should be implemented some other way so I can change the PR accordingly |
pissang
reviewed
May 27, 2022
Contributor
|
@villebro Thanks for the wonderful work! All looks good to me except a tiny code style issue. |
pissang
approved these changes
May 28, 2022
Contributor
|
This could fix a lot of issues. I have added in PR description |
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Ovilia
added a commit
to apache/echarts-doc
that referenced
this pull request
Jun 13, 2022
Ovilia
added
PR: doc ready
and removed
PR: awaiting doc
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
This PR adds a new property
stackStrategyto theSeriesStackOptionMixinwhich defaults tosamesign(current behavior). Associated PR on the docs repo: apache/echarts-doc#255Fixed issues
Details
Before: What was the problem?
Currently stacking is only applied if the cumulative sum has the same sign as the value to be stacked. This makes it impossible to mix positive and negative values in the same series, something typically needed when creating confidence bands:
After: How is it fixed in this PR?
Here we introduce the following new stacking options:
all: stack all values, irrespective of the sign of the stackable value:positive: only stack positive values:negative: only stack negative values:We also add the strategy
samesignwhich corresponds to the current behavior which we default to to avoid introducing a breaking change. However, I propose defaulting toallin the next major version, as I assume this is the behavior users will expect to see.Misc
Related test cases or examples to use the new APIs
New test cases added to the
area-stack.htmltest.Others
Merging options
Other information