Skip to content

chore(plugin-chart-echarts): bump ECharts to 5.4.0#21916

Merged
villebro merged 5 commits into
apache:masterfrom
villebro:villebro/bump-echarts-5.4.0
Oct 24, 2022
Merged

chore(plugin-chart-echarts): bump ECharts to 5.4.0#21916
villebro merged 5 commits into
apache:masterfrom
villebro:villebro/bump-echarts-5.4.0

Conversation

@villebro
Copy link
Copy Markdown
Member

@villebro villebro commented Oct 22, 2022

SUMMARY

Bump ECharts to latest version (5.4.0). Release notes since current 5.3.2 version:

Notable changes for Superset:

This addresses the regression introduced by #20408 that had to be reverted by #20571 and adds storybooks for both confidence intervals and stacking with null values:

Confidence interval storybook (note the lower bound displaying correctly with negative values):
image

Stacking with null values (the repro case from #20571):
image

In addition, a few previous storybooks were incorrectly using camelcase control values in the formData causing the rawFormData to render incorrectly, which lead to the x-axis formatter to not function properly. Now the x-axis displays with smart_date instead of showing epochs for all ECharts storybooks.

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 22, 2022

Codecov Report

Merging #21916 (fd69a69) into master (c2834cc) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #21916      +/-   ##
==========================================
- Coverage   66.91%   66.91%   -0.01%     
==========================================
  Files        1807     1807              
  Lines       69139    69142       +3     
  Branches     7392     7395       +3     
==========================================
+ Hits        46266    46268       +2     
  Misses      20963    20963              
- Partials     1910     1911       +1     
Flag Coverage Δ
javascript 53.32% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lugin-chart-echarts/src/Timeseries/transformers.ts 49.61% <0.00%> (-0.39%) ⬇️
...c/components/Chart/DrillDetail/DrillDetailPane.tsx 82.71% <0.00%> (+0.43%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhaoyongjie
Copy link
Copy Markdown
Member

/testenv up FEATURE_GENERIC_CHART_AXES=true

@github-actions
Copy link
Copy Markdown
Contributor

@zhaoyongjie Ephemeral environment spinning up at http://34.219.50.78:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Copy Markdown
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM loves to display the null value on the x-axis.

Copy link
Copy Markdown
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@villebro
Copy link
Copy Markdown
Member Author

Here's a dashboard on the eph env with the repro test case from the revert PR: http://34.219.50.78:8080/superset/dashboard/11

Copy link
Copy Markdown
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Glad to have this one back in!

@villebro villebro merged commit f5977ca into apache:master Oct 24, 2022
@github-actions
Copy link
Copy Markdown
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added the 🚢 2.1.3 First shipped in 2.1.3 label Feb 18, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 First shipped in 2.1.0 and removed 🚢 2.1.3 First shipped in 2.1.3 labels Mar 13, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0 First shipped in 2.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants