chore(plugin-chart-echarts): bump ECharts to 5.4.0#21916
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21916 +/- ##
==========================================
- Coverage 66.91% 66.91% -0.01%
==========================================
Files 1807 1807
Lines 69139 69142 +3
Branches 7392 7395 +3
==========================================
+ Hits 46266 46268 +2
Misses 20963 20963
- Partials 1910 1911 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
/testenv up FEATURE_GENERIC_CHART_AXES=true |
|
@zhaoyongjie Ephemeral environment spinning up at http://34.219.50.78:8080. Credentials are |
zhaoyongjie
left a comment
There was a problem hiding this comment.
LGTM loves to display the null value on the x-axis.
|
Here's a dashboard on the eph env with the repro test case from the revert PR: http://34.219.50.78:8080/superset/dashboard/11 |
rusackas
left a comment
There was a problem hiding this comment.
Thank you! Glad to have this one back in!
|
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Bump ECharts to latest version (5.4.0). Release notes since current 5.3.2 version:
Notable changes for Superset:
labelLinemay not be hidden whenminShowLabelRadianis specified echarts#17412This addresses the regression introduced by #20408 that had to be reverted by #20571 and adds storybooks for both confidence intervals and stacking with null values:
Confidence interval storybook (note the lower bound displaying correctly with negative values):

Stacking with null values (the repro case from #20571):

In addition, a few previous storybooks were incorrectly using camelcase control values in the
formDatacausing therawFormDatato render incorrectly, which lead to the x-axis formatter to not function properly. Now the x-axis displays withsmart_dateinstead of showing epochs for all ECharts storybooks.TESTING INSTRUCTIONS
ADDITIONAL INFORMATION