fix: Revert #20408 (stacking negative values in echarts bar chart)#20571
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20571 +/- ##
=======================================
Coverage 66.81% 66.81%
=======================================
Files 1752 1752
Lines 65478 65478
Branches 6916 6916
=======================================
Hits 43750 43750
Misses 19980 19980
Partials 1748 1748
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
michael-s-molina
pushed a commit
that referenced
this pull request
Jul 6, 2022
9 tasks
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
…itive values (apache#20408)" (apache#20571) This reverts commit 14779af.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit c959d92.
The PR being reverted bumped echarts and changes the stacking method to allow proper stacking of negative values (cool!). However, if a dataset happens to display
nullvalues as bar segments, clicking on the legend causes the chart display to become VERY erratic in terms of what's displayed/hidden in the stacked bars - things disappear completely!SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
problem_bar.mp4
After: coming soon... but it works, trust me ;)
TESTING INSTRUCTIONS
Create a dataset with this query
...then make Timeseries Bar Chart V2 as shown in the GIF. Click around on the labels and see if you see all the right bars at all times.
ADDITIONAL INFORMATION