Skip to content

feat(plugin-chart-echarts): Support stacking negative and positive values#20408

Merged
kgabryje merged 1 commit into
apache:masterfrom
kgabryje:fix/echarts-stacking
Jun 16, 2022
Merged

feat(plugin-chart-echarts): Support stacking negative and positive values#20408
kgabryje merged 1 commit into
apache:masterfrom
kgabryje:fix/echarts-stacking

Conversation

@kgabryje
Copy link
Copy Markdown
Member

@kgabryje kgabryje commented Jun 16, 2022

SUMMARY

Upgrade echarts to 5.3.3 to support stacking negative and positive values.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

image

After:

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

michael-s-molina
michael-s-molina approved these changes Jun 16, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 16, 2022

Codecov Report

Merging #20408 (132b665) into master (1665403) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20408   +/-   ##
=======================================
  Coverage   66.67%   66.67%           
=======================================
  Files        1739     1739           
  Lines       65135    65135           
  Branches     6897     6897           
=======================================
  Hits        43427    43427           
  Misses      19955    19955           
  Partials     1753     1753
Flag Coverage Δ
javascript 51.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lugin-chart-echarts/src/Timeseries/transformers.ts 50.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1665403...132b665. Read the comment docs.

@kgabryje kgabryje merged commit c959d92 into apache:master Jun 16, 2022
michael-s-molina pushed a commit that referenced this pull request Jun 23, 2022
@kgabryje @michael-s-molina
feat(plugin-chart-echarts): Support stacking negative and positive va…
ce98079 
…lues (#20408)

(cherry picked from commit c959d92)
sadpandajoe added a commit to preset-io/superset that referenced this pull request Jun 30, 2022
@sadpandajoe
Revert "feat(plugin-chart-echarts): Support stacking negative and pos…
95ee9e9 
…itive values (apache#20408)"

This reverts commit c959d92.
rusackas added a commit that referenced this pull request Jun 30, 2022
@rusackas
Revert "feat(plugin-chart-echarts): Support stacking negative and pos…
0314543 
…itive values (#20408)"

This reverts commit c959d92.
@rusackas rusackas mentioned this pull request Jun 30, 2022
Merged
9 tasks
rusackas added a commit that referenced this pull request Jun 30, 2022
@rusackas
Revert "feat(plugin-chart-echarts): Support stacking negative and pos…
f5f8dde 
…itive values (#20408)" (#20571)

This reverts commit c959d92.
michael-s-molina pushed a commit that referenced this pull request Jul 6, 2022
@rusackas @michael-s-molina
Revert "feat(plugin-chart-echarts): Support stacking negative and pos…
4dcc805 
…itive values (#20408)" (#20571)

This reverts commit c959d92.

(cherry picked from commit f5f8dde)
@villebro villebro mentioned this pull request Oct 22, 2022
Merged
9 tasks
@mistercrunch mistercrunch added 🍒 2.0.0 Cherry-picked to 2.0.0 🍒 2.0.1 Cherry-picked to 2.0.1 🚢 2.1.3 First shipped in 2.1.3 labels Feb 18, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 First shipped in 2.1.0 and removed 🚢 2.1.3 First shipped in 2.1.3 labels Mar 13, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
@kgabryje
feat(plugin-chart-echarts): Support stacking negative and positive va…
14779af 
…lues (apache#20408)
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
@rusackas
Revert "feat(plugin-chart-echarts): Support stacking negative and pos…
ad2f562 
…itive values (apache#20408)" (apache#20571)

This reverts commit 14779af.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geido geido geido approved these changes

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS v2.0 🍒 2.0.0 Cherry-picked to 2.0.0 🍒 2.0.1 Cherry-picked to 2.0.1 🚢 2.1.0 First shipped in 2.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kgabryje @geido @michael-s-molina @mistercrunch