bug(tooltip): tooltip arrow will follow borderWidth. close #14373 by g7i · Pull Request #14393 · apache/echarts

g7i · 2021-03-03T18:59:56Z

Brief Information

This pull request is in the type of:

bug fixing
new feature
others

What does this PR do?

Tooltip arrow will follow the specified borderWidth in tooltip.

Fixed issues

fixes: #14373

Are there any API changes?

The API has been changed.

Related test cases or examples to use the new APIs

Checkout test/scatter.html

Others

Merging options

Please squash the commits into a single one when merge.

Other information

echarts-bot · 2021-03-03T18:59:58Z

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

g7i · 2021-04-26T08:45:22Z

Hey, do I need to resolve the conflicts or the maintainer will resolve?

pissang · 2021-04-26T13:25:29Z

@g7i Hi, It will be great if you can resolve the conflicts

pissang · 2021-04-27T03:00:05Z

@g7i Please don't commit the files in dist and i18n folder. They are only updated before release

g7i · 2021-04-27T03:14:35Z

@g7i Please don't commit the files in dist and i18n folder. They are only updated before release

Ohh okay, sorry did it by mistake. Now reverted the changes. Thanks....

plainheart

Left my several thoughts. We can discuss them together whether they are reasonable or not.

pissang · 2021-05-27T06:03:06Z

Seems we can't make it merged in 5.1.2. Let's continue it in the next 5.2.0

g7i · 2021-05-30T12:49:50Z

Okay, thanks. I was away for a while that's why unable to work on it. Will fix it asap.

g7i · 2021-06-12T10:08:01Z

@pissang @plainheart I have addressed all the comments for changes. Please re-review it. Thank you.

Co-authored-by: Zhongxiang.Wang <yhen@all-my-life.cn>

g7i · 2021-07-06T08:35:45Z

Thanks for helping me out :)

plainheart · 2021-07-06T08:38:20Z

@g7i Really thank you for the work!
@pissang Please help take a double check. I think it should be working well.

plainheart · 2021-07-06T08:42:17Z

Is it ready to be merged now?

It looks good to me now. If other maintainers have no issue with this, it will be merged.

g7i · 2021-07-06T08:44:30Z

Is it ready to be merged now?

It looks good to me now. If other maintainers have no issue with this, it will be merged.

Alright, thanks 🎉

pissang · 2021-07-15T06:27:21Z

LGTM. @g7i Thanks for keeping improving your PR and @plainheart thanks for the detailed review.

already approved by him

echarts-bot · 2021-07-15T06:33:11Z

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

1) tweak the calculation of tooltip offset to make it look not so near to the target element. #14393 2) remove unnecessary `getOuterSize` method beacuse `getSize` is now using `offsetWidth/offsetHeight` that contains the `borderWidth`.

bug(tooltip): tooltip arrow will follow borderWidth. close apache#14373

75a6925

echarts-bot Bot added the PR: awaiting review label Mar 3, 2021

pull-request-size Bot added the size/S label Mar 3, 2021

plainheart added the PR: first-time contributor label Mar 8, 2021

Ovilia added this to the 5.1.1 milestone Apr 6, 2021

pissang modified the milestones: 5.1.1, 5.1.2 Apr 22, 2021

merged with master to resolve conflicts

5a8bb26

g7i added 2 commits April 27, 2021 08:39

reset build files

cf94320

reset build files

a7df002

pissang reviewed Apr 27, 2021

View reviewed changes

Comment thread src/component/tooltip/TooltipHTMLContent.ts Outdated

Comment thread src/component/tooltip/TooltipHTMLContent.ts Outdated

arrow position made dynamic based on borderWidth

2e1270b

pissang requested a review from susiwen8 May 5, 2021 02:28

susiwen8 reviewed May 6, 2021

View reviewed changes

Comment thread src/component/tooltip/TooltipHTMLContent.ts Outdated

declarations moved after if block

f84df5b

plainheart reviewed May 6, 2021

View reviewed changes

Comment thread src/component/tooltip/TooltipHTMLContent.ts Outdated

plainheart previously requested changes May 6, 2021

View reviewed changes

Comment thread src/component/tooltip/TooltipHTMLContent.ts Outdated

echarts-bot Bot added PR: revision needed and removed PR: awaiting review labels May 6, 2021

tooltip position fixed

2b39cb4

echarts-bot Bot added PR: awaiting review and removed PR: revision needed labels May 19, 2021

pull-request-size Bot added size/M and removed size/S labels May 19, 2021

g7i requested a review from plainheart May 19, 2021 14:56

plainheart reviewed May 19, 2021

View reviewed changes

Comment thread src/component/tooltip/TooltipView.ts Outdated

Comment thread src/component/tooltip/TooltipHTMLContent.ts Outdated

Comment thread src/component/tooltip/TooltipHTMLContent.ts Outdated

Comment thread src/component/tooltip/TooltipView.ts

pissang modified the milestones: 5.1.2, 5.2.0 May 27, 2021

g7i added 2 commits June 12, 2021 15:33

requested changes performed

2f7eb1e

Merge remote-tracking branch 'upstream/master' into fix-14373

37c4037

pissang added the priority: high label Jun 29, 2021

pissang reviewed Jun 30, 2021

View reviewed changes

Comment thread src/component/tooltip/TooltipHTMLContent.ts Outdated

fix: calculations made more accurate

6d02c13

plainheart reviewed Jul 6, 2021

View reviewed changes

Comment thread src/component/tooltip/TooltipHTMLContent.ts Outdated

Comment thread src/component/tooltip/TooltipHTMLContent.ts Outdated

Comment thread src/component/tooltip/TooltipHTMLContent.ts Outdated

g7i and others added 2 commits July 6, 2021 14:03

Update src/component/tooltip/TooltipHTMLContent.ts

607bf95

Co-authored-by: Zhongxiang.Wang <yhen@all-my-life.cn>

Update src/component/tooltip/TooltipHTMLContent.ts

34847b4

Co-authored-by: Zhongxiang.Wang <yhen@all-my-life.cn>

plainheart reviewed Jul 6, 2021

View reviewed changes

Comment thread src/component/tooltip/TooltipHTMLContent.ts Outdated

g7i and others added 2 commits July 6, 2021 14:04

Update src/component/tooltip/TooltipHTMLContent.ts

71d2be3

Co-authored-by: Zhongxiang.Wang <yhen@all-my-life.cn>

Update src/component/tooltip/TooltipHTMLContent.ts

37d9ab8

Co-authored-by: Zhongxiang.Wang <yhen@all-my-life.cn>

pissang approved these changes Jul 15, 2021

View reviewed changes

pissang merged commit 0d30818 into apache:master Jul 15, 2021

echarts-bot Bot removed the PR: awaiting review label Jul 15, 2021

plainheart mentioned this pull request Aug 24, 2021

fix(tooltip): tweak the calculation of tooltip offset to make it look not so near to the target element. #15588

Merged

6 tasks

Conversation

g7i commented Mar 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Brief Information

What does this PR do?

Fixed issues

Are there any API changes?

Related test cases or examples to use the new APIs

Others

Merging options

Other information

Uh oh!

echarts-bot Bot commented Mar 3, 2021

Uh oh!

g7i commented Apr 26, 2021

Uh oh!

pissang commented Apr 26, 2021

Uh oh!

pissang commented Apr 27, 2021

Uh oh!

g7i commented Apr 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

plainheart left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pissang commented May 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

g7i commented May 30, 2021

Uh oh!

g7i commented Jun 12, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

g7i commented Jul 6, 2021

Uh oh!

plainheart commented Jul 6, 2021

Uh oh!

plainheart commented Jul 6, 2021

Uh oh!

g7i commented Jul 6, 2021

Uh oh!

pissang commented Jul 15, 2021

Uh oh!

echarts-bot Bot commented Jul 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

g7i commented Mar 3, 2021 •

edited

Loading

g7i commented Apr 27, 2021 •

edited

Loading

pissang commented May 27, 2021 •

edited

Loading