fix(tooltip): tweak the calculation of tooltip offset to make it look not so near to the target element.#15588
Merged
Merged
Conversation
1) tweak the calculation of tooltip offset to make it look not so near to the target element. #14393 2) remove unnecessary `getOuterSize` method beacuse `getSize` is now using `offsetWidth/offsetHeight` that contains the `borderWidth`.
|
Thanks for your contribution! The pull request is marked to be |
Contributor
|
Is it planned to be included in this version? |
Member
Author
|
Yes. Because it seems too near to the element currently. But the second change is optional. I just think it is no longer necessary. |
100pah
approved these changes
Aug 24, 2021
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
tweak the calculation of tooltip offset to make it look not so near to the target element. Appreciated it if there is a better solution.
remove unnecessary
getOuterSizemethod beacusegetSizeis now usingoffsetWidth/offsetHeightthat contains theborderWidth. (Please ensure it has no side effect)Fixed issues
Details
Before: What was the problem?
After: How is it fixed in this PR?
Misc
Related test cases or examples to use the new APIs
Please refer to
scatter.htmlornew-tooltip.htmlOthers
Merging options
Other information