Skip to content

Conversation

@xinggit
Copy link
Contributor

@xinggit xinggit commented Mar 22, 2021

What is the purpose of the change

The page url is https://ci.apache.org/projects/flink/flink-docs-release-1.12/zh/flinkDev/ide_setup.html
The markdown file is located in 'docs/content.zh/docs/flinkDev/ide_setup.md' now.

The doc is still in English on the master branch.So translate "Importing Flink into an IDE" page into Chinese

Brief change log

translate 'docs/content.zh/docs/flinkDev/ide_setup.md' file

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? no

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 22, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 426c888 (Fri May 28 09:11:22 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 22, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@xinggit
Copy link
Contributor Author

xinggit commented Mar 31, 2021

cc @wuchong @xccui @klion26 . could you help to review this? thanks

@xinggit
Copy link
Contributor Author

xinggit commented Apr 21, 2021

cc @wuchong Excuse me. I have resolved two conflicts for this merge request, please Could you help me review it as soon as possible, and then give me some comments

@wuchong
Copy link
Member

wuchong commented Apr 22, 2021

Thanks @xinggit for the contribution, the translation looks good to me.

However, please DO NOT use git merge to fix conflicts, otherwise, comitters need to resolve the conflicts again when rebasing your branch. Please use git rebase to rebase your branch to latest master and fix conflicts. IntelliJ IDEA also provide an easy tool to do git rebase, you can find the tool via VCS -> Git -> Rebase.

zhaoxing and others added 15 commits April 22, 2021 15:18
fsk119 and others added 21 commits April 22, 2021 15:59
…TE TABLE' statement.

This commit tries to
1. resolve the conflicts
2. revert the changes made on old planner
3. apply spotless formatting
4. fix DDL missing `TEMPORARY` keyword for temporary table
5. display table's full object path as catalog.db.table
6. support displaying the expanded query for view
7. add view test in CatalogTableITCase, and adapt sql client test to the new test framework
8. adapt docs

This closes apache#13011
…t declare managed memory for Python operators

This closes apache#15665.
…precision isn't matching with declared DataType

This closes apache#15689
Additionally, set speed up the AdaptiveScheduler ITCases by configuring a very low
jobmanager.adaptive-scheduler.resource-stabilization-timeout.
When this incorrect assertion is violated, the scheduler can trip into an unrecoverable
failover loop.
…IncrementalAggregate.out

After FLINK-22298 is finished, the ExecNode's id should always start from 1 in the json plan tests, while the testIncrementalAggregate.out was overrided by FLINK-20613

This closes apache#15698
… on persisting

Exception can be thrown for example if task is being cancelled. This was leading to
same buffer being recycled twice. Most of the times that was just leading to an
IllegalReferenceCount being thrown, which was ignored, as this task was being cancelled.
However on rare occasions this buffer could have been picked up by another task
after being recycled for the first time, recycled second time and being picked up
by another (third task). In that case we had two users of the same buffer, which
could lead to all sort of data corruptions.
[FLINK-XXXX] Draft separation of leader election and creation of JobMasterService

[FLINK-XXXX] Continued work on JobMasterServiceLeadershipRunner

[FLINK-XXXX] Integrate RunningJobsRegistry, Cancelling state and termination future watching

[FLINK-XXXX] Delete old JobManagerRunnerImpl classes

[FLINK-22001] Add tests for DefaultJobMasterServiceProcess

[FLINK-22001][hotfix] Clean up ITCase a bit

[FLINK-22001] Add missing check for empty job graph

[FLINK-22001] Rename JobMasterServiceFactoryNg to JobMasterServiceFactory

This closes apache#15715.
@xinggit
Copy link
Contributor Author

xinggit commented Apr 22, 2021

Thank you very much for your review and suggestion, but I'm sorry that I made a mistake and added a lot of commits.
I will open a new PR for the merge request

@xinggit xinggit closed this Apr 22, 2021
@xinggit xinggit deleted the FLINK-21903-PR branch April 22, 2021 09:18
xinggit pushed a commit to xinggit/flink that referenced this pull request Apr 22, 2021
xinggit pushed a commit to xinggit/flink that referenced this pull request Apr 22, 2021
xinggit pushed a commit to xinggit/flink that referenced this pull request Apr 22, 2021
xinggit pushed a commit to xinggit/flink that referenced this pull request Apr 22, 2021
xinggit pushed a commit to xinggit/flink that referenced this pull request Apr 22, 2021
xinggit pushed a commit to xinggit/flink that referenced this pull request Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.