Skip to content

[FLINK-25797][docs-zh] Translate datastream/formats/parquet.md page into Chinese. #18646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MartijnVisser merged 1 commit into from
Mar 18, 2022
Merged

[FLINK-25797][docs-zh] Translate datastream/formats/parquet.md page into Chinese. #18646

MartijnVisser merged 1 commit into from
Mar 18, 2022

Conversation

@wangzhiwubigdata
Copy link
Contributor

@wangzhiwubigdata wangzhiwubigdata commented Feb 7, 2022

What is the purpose of the change

Translate datastream/formats/parquet.md page into Chinese.

Brief change log

Translate datastream/formats/parquet.md page into Chinese.

Verifying this change

A pure documentation task.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @public(Evolving): (yes / no)
  • The serializers: (yes / no)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 7, 2022

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit f4008aa (Mon Feb 07 14:05:07 UTC 2022)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 7, 2022 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

RocMarshal
RocMarshal approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@RocMarshal RocMarshal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. @wangzhiwubigdata .
LGTM +1 (non-binding.)
Hi, @wuchong Would you mind helping to check it ?

@RocMarshal
Copy link
Contributor

RocMarshal commented Mar 1, 2022

Hi, @wangzhiwubigdata Would you mind checking the conflicts ?

@wangzhiwubigdata
Copy link
Contributor Author

wangzhiwubigdata commented Mar 15, 2022

@flinkbot run azure

@wangzhiwubigdata
Copy link
Contributor Author

wangzhiwubigdata commented Mar 15, 2022 •
edited
Loading

i have resolved the conflicts. plz check. @RocMarshal

RocMarshal
RocMarshal approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangzhiwubigdata Thanks for the update.
LGTM +1 now(non-binding).

@MartijnVisser @wuchong PTAL. Thanks.

@MartijnVisser
Copy link
Contributor

MartijnVisser commented Mar 16, 2022

Hi @wangzhiwubigdata - I would have loved to merge this but unfortunately there was a follow-up ticket created (https://issues.apache.org/jira/browse/FLINK-26604) which included several improvements on the Doc in general. Could you update your PR to include the latest changes? You can find it at #19083

@RocMarshal Thanks for the review! Hope that I'll be able to merge this soon.

@wangzhiwubigdata
Copy link
Contributor Author

wangzhiwubigdata commented Mar 17, 2022

@RocMarshal i have resolved the conflicts, plz take a look.

JingGe
JingGe requested changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@JingGe JingGe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wangzhiwubigdata for driving this PR. I just left some comments. Please let me know your thoughts.

@wangzhiwubigdata
Copy link
Contributor Author

wangzhiwubigdata commented Mar 18, 2022

@JingGe Hi, i have carefully read your comments. Thanks a lot for your suggestions.
At first, short sentences like 「DataStream containing Parquet records as Avro Reflect records」 really confused me.
Again, thank you for your help. now the translation looks more fluent and easy to understand.

@MartijnVisser @RocMarshal Please take a look at the update. thanks.

JingGe
JingGe approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@JingGe JingGe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wangzhiwubigdata. LGTM

RocMarshal
RocMarshal reviewed Mar 18, 2022
View reviewed changes
Copy link
Contributor

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wangzhiwubigdata for the update and @JingGe review.
LGTM +1.

@MartijnVisser
Copy link
Contributor

MartijnVisser commented Mar 18, 2022

@wangzhiwubigdata Thanks for the PR and the fixes. I've rebased and squashed your commits. I'm going to let the CI finish and then I'll merge it.

@JingGe @RocMarshal Thank you for your reviews and approval. Much appreciated!

MartijnVisser pushed a commit to wangzhiwubigdata/flink that referenced this pull request Mar 18, 2022
@JingGe @wangzhiwubigdata @MartijnVisser
[FLINK-25797][Docs] Translate datastream/formats/parquet.md page into…
6dee228 
… Chinese. This closes apache#18646

Co-authored-by: Jing Ge <gejing@gmail.com>
Co-authored-by: wangzhiwubigdata <changye.wcy@cainiao.com>
Co-authored-by: Zhiwu Wang <2827873682@qq.com>
@MartijnVisser MartijnVisser self-assigned this Mar 18, 2022
@JingGe @wangzhiwubigdata @MartijnVisser
[FLINK-25797][Docs] Translate datastream/formats/parquet.md page into…
99da396 
… Chinese. This closes apache#18646

Co-authored-by: Jing Ge <gejing@gmail.com>
Co-authored-by: wangzhiwubigdata <changye.wcy@cainiao.com>
Co-authored-by: Zhiwu Wang <2827873682@qq.com>
@JingGe
Copy link
Contributor

JingGe commented Mar 18, 2022

@flinkbot run azure

@MartijnVisser MartijnVisser merged commit 0f4b17c into apache:master Mar 18, 2022
@MartijnVisser
Copy link
Contributor

MartijnVisser commented Mar 18, 2022

@wangzhiwubigdata Thanks for the PR - Can you also create the backport to release-1.15 branch?

golden-yang pushed a commit to golden-yang/flink that referenced this pull request Mar 19, 2022
@JingGe @wangzhiwubigdata
[FLINK-25797][Docs] Translate datastream/formats/parquet.md page into…
da90399 
… Chinese. This closes apache#18646

Co-authored-by: Jing Ge <gejing@gmail.com>
Co-authored-by: wangzhiwubigdata <changye.wcy@cainiao.com>
Co-authored-by: Zhiwu Wang <2827873682@qq.com>
@MartijnVisser MartijnVisser mentioned this pull request Apr 4, 2022
Merged
JasonLeeCoding pushed a commit to JasonLeeCoding/flink that referenced this pull request May 27, 2022
@JingGe @wangzhiwubigdata @JasonLeeCoding
[FLINK-25797][Docs] Translate datastream/formats/parquet.md page into…
9ca22bb 
… Chinese. This closes apache#18646

Co-authored-by: Jing Ge <gejing@gmail.com>
Co-authored-by: wangzhiwubigdata <changye.wcy@cainiao.com>
Co-authored-by: Zhiwu Wang <2827873682@qq.com>
zstraw pushed a commit to zstraw/flink that referenced this pull request Jul 4, 2022
@JingGe @wangzhiwubigdata
[FLINK-25797][Docs] Translate datastream/formats/parquet.md page into…
2b343b6 
… Chinese. This closes apache#18646

Co-authored-by: Jing Ge <gejing@gmail.com>
Co-authored-by: wangzhiwubigdata <changye.wcy@cainiao.com>
Co-authored-by: Zhiwu Wang <2827873682@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RocMarshal RocMarshal RocMarshal approved these changes

@JingGe JingGe JingGe approved these changes

Assignees

@MartijnVisser MartijnVisser

Labels

component=Documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wangzhiwubigdata @flinkbot @RocMarshal @MartijnVisser @JingGe @rmetzger