[FLINK-26604][doc] add more information for Avro records support and clean up redundant content of bounded and unbounded data #19083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingGe
force-pushed
the
FLINK-26604-avroparquet-doc
branch
from
04540d4 to
ff9339f
Compare
JingGe
force-pushed
the
FLINK-26604-avroparquet-doc
branch
from
ff9339f to
8cb4207
Compare
Collaborator
MartijnVisser
requested changes
Mar 14, 2022
Contributor
MartijnVisser
left a comment
MartijnVisser
left a comment
There was a problem hiding this comment.
Thanks for the PR @JingGe - I had a couple of comments, let me know what you think.
JingGe
force-pushed
the
FLINK-26604-avroparquet-doc
branch
from
8cb4207 to
05abc4a
Compare
MartijnVisser
requested changes
Mar 15, 2022
Contributor
MartijnVisser
left a comment
MartijnVisser
left a comment
There was a problem hiding this comment.
@JingGe I've updated my review after our offline conversation Jing. Let me know what you think.
Contributor
Author
|
Thanks @MartijnVisser for your effort! The content has been updated. |
JingGe
force-pushed
the
FLINK-26604-avroparquet-doc
branch
2 times, most recently
from
ae62b77 to
2533912
Compare
…clean up redundant content of bounded and unbounded data. - mvn dependency - using namespace in schema for reflect records [FLINK-26604][doc] bug fix
JingGe
force-pushed
the
FLINK-26604-avroparquet-doc
branch
from
2533912 to
3377a70
Compare
Contributor
Author
|
FYI: I've copied the content to the content.zh/.../formats/parquet.md and squashed commits. The PR is ready to be merged. |
MartijnVisser
approved these changes
Mar 16, 2022
Contributor
MartijnVisser
left a comment
MartijnVisser
left a comment
There was a problem hiding this comment.
Thanks a lot for the improvements @JingGe - LGTM
flinkbot
added
component=Documentation
component=Formats
and removed
component=<none>
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Update the document based on the feedback of release test task FLINK-26301.
Brief change log
(for example:)
Verifying this change
This change is a trivial document update.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation