[FLINK-11234][table][tests] fix ExternalTableCatalogBuilder::supportsBatch #7386
+11
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y table - fix the logic in supportsBatch to properly declare a batch-only table - adjust CommonTestData to provide batch-only or streaming-only tables Signed-off-by: EronWright <eronwright@gmail.com>
Contributor
Author
|
@bowenli86 and/or @twalthr please take a look, thanks. |
twalthr
approved these changes
Jan 4, 2019
Contributor
twalthr
left a comment
twalthr
left a comment
There was a problem hiding this comment.
Thank you @EronWright. Will merge this...
asfgit
pushed a commit
that referenced
this pull request
Jan 4, 2019
… a batch-only table - fix the logic in supportsBatch to properly declare a batch-only table - adjust CommonTestData to provide batch-only or streaming-only tables This closes #7386.
asfgit
pushed a commit
that referenced
this pull request
Jan 4, 2019
… a batch-only table - fix the logic in supportsBatch to properly declare a batch-only table - adjust CommonTestData to provide batch-only or streaming-only tables This closes #7386.
JTaky
pushed a commit
to JTaky/flink
that referenced
this pull request
Jan 14, 2019
… a batch-only table - fix the logic in supportsBatch to properly declare a batch-only table - adjust CommonTestData to provide batch-only or streaming-only tables This closes apache#7386.
tisonkun
pushed a commit
to tisonkun/flink
that referenced
this pull request
Jan 17, 2019
… a batch-only table - fix the logic in supportsBatch to properly declare a batch-only table - adjust CommonTestData to provide batch-only or streaming-only tables This closes apache#7386.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: EronWright eronwright@gmail.com
What is the purpose of the change
Fix the
ExternalTableCatalogBuilderto be able to produce batch-only tables, and test this more thoroughly by correctly labeling the tables produced byCommonTestData.Brief change log
Verifying this change
This change is already covered by existing tests, such as
ExternalCatalogTest.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation