Skip to content

[hotfix][javadocs][table] Fix typos in JavaDocs for Table API #7388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
EronWright wants to merge 2 commits into from
Closed

[hotfix][javadocs][table] Fix typos in JavaDocs for Table API #7388

EronWright wants to merge 2 commits into from

Conversation

@EronWright
Copy link
Contributor

@EronWright EronWright commented Dec 31, 2018 •
edited
Loading

Brief change log

  • Fix a couple of typos.
  • Added a constant on ConnectorDescriptorValidator which is referred to only by a (new) JavaDoc comment, for symmetry with FormatDescrriptorValidator.

Note: based on PR #7386. Focus on 765a19e

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? N/A

@EronWright
FLINK-11234 - ExternalTableCatalogBuilder unable to build a batch-onl…
1517455 
…y table

- fix the logic in supportsBatch to properly declare a batch-only table
- adjust CommonTestData to provide batch-only or streaming-only tables

Signed-off-by: EronWright <eronwright@gmail.com>
@EronWright
[hotfix][table] Fix typos in Table javadoc.
765a19e 
Signed-off-by: EronWright <eronwright@gmail.com>
@EronWright EronWright mentioned this pull request Dec 31, 2018
Closed
asfgit pushed a commit that referenced this pull request Jan 4, 2019
@EronWright @twalthr
[hotfix] [table] Fix typos in Table javadoc.
b6ce4e4 
This closes #7388.
@asfgit asfgit closed this in cef75fe Jan 4, 2019
tisonkun pushed a commit to tisonkun/flink that referenced this pull request Jan 17, 2019
@EronWright @tisonkun
[hotfix] [table] Fix typos in Table javadoc.
dc162f6 
This closes apache#7388.
@EronWright EronWright deleted the javadoc-hotfix branch March 19, 2019 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@EronWright