Skip to content

[hotfix][javadocs][table] Fix typos in JavaDocs for Table API #7388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EronWright wants to merge 2 commits into from
Closed

[hotfix][javadocs][table] Fix typos in JavaDocs for Table API #7388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1517455
FLINK-11234 - ExternalTableCatalogBuilder unable to build a batch-onl…
EronWright Dec 31, 2018
765a19e
[hotfix][table] Fix typos in Table javadoc.
EronWright Dec 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...nk-table-common/src/main/java/org/apache/flink/table/descriptors/ConnectorDescriptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ protected final boolean isFormatNeeded() {

/**
* Converts this descriptor into a set of connector properties. Usually prefixed with
* {@link FormatDescriptorValidator#FORMAT}.
* {@link ConnectorDescriptorValidator#CONNECTOR}.
*/
protected abstract Map<String, String> toConnectorProperties();
}
5 changes: 5 additions & 0 deletions ...common/src/main/java/org/apache/flink/table/descriptors/ConnectorDescriptorValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@
@Internal
public abstract class ConnectorDescriptorValidator implements DescriptorValidator {

/**
* Prefix for connector-related properties.
*/
public static final String CONNECTOR = "connector";

/**
* Key for describing the type of the connector. Usually used for factory discovery.
*/
Expand Down
4 changes: 2 additions & 2 deletions ...ries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,8 @@ class ExternalCatalogTableBuilder(private val connectorDescriptor: ConnectorDesc
* Explicitly declares this external table for supporting only batch environments.
*/
def supportsBatch(): ExternalCatalogTableBuilder = {
isBatch = false
isStreaming = true
isBatch = true
isStreaming = false
this
}

Expand Down
2 changes: 1 addition & 1 deletion ...s/flink-table/src/main/scala/org/apache/flink/table/factories/BatchTableSinkFactory.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import java.util
import org.apache.flink.table.sinks.BatchTableSink

/**
* A factory to create configured table sink instances in a streaming environment based on
* A factory to create configured table sink instances in a batch environment based on
* string-based properties. See also [[TableFactory]] for more information.
*
* @tparam T type of records that the factory consumes
Expand Down
12 changes: 9 additions & 3 deletions ...ries/flink-table/src/test/scala/org/apache/flink/table/runtime/utils/CommonTestData.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,9 @@ object CommonTestData {
.withSchema(schemaDesc1)

if (isStreaming) {
externalTableBuilder1.inAppendMode()
externalTableBuilder1.supportsStreaming().inAppendMode()
} else {
externalTableBuilder1.supportsBatch()
}

val csvRecord2 = Seq(
Expand Down Expand Up @@ -126,7 +128,9 @@ object CommonTestData {
.withSchema(schemaDesc2)

if (isStreaming) {
externalTableBuilder2.inAppendMode()
externalTableBuilder2.supportsStreaming().inAppendMode()
} else {
externalTableBuilder2.supportsBatch()
}

val tempFilePath3 = writeToTempFile("", "csv-test3", "tmp")
Expand All @@ -145,7 +149,9 @@ object CommonTestData {
.withSchema(schemaDesc3)

if (isStreaming) {
externalTableBuilder3.inAppendMode()
externalTableBuilder3.supportsStreaming().inAppendMode()
} else {
externalTableBuilder3.supportsBatch()
}

val catalog = new InMemoryExternalCatalog("test")
Expand Down