[FLINK-11237] [table] Enhance LocalExecutor to wrap TableEnvironment w/ classloader #7389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y table - fix the logic in supportsBatch to properly declare a batch-only table - adjust CommonTestData to provide batch-only or streaming-only tables Signed-off-by: EronWright <eronwright@gmail.com>
Signed-off-by: EronWright <eronwright@gmail.com>
…w/ user classloader - use the context classloader for all interactions with TableEnvironment Signed-off-by: EronWright <eronwright@gmail.com>
Contributor
Author
|
@twalthr any reservation about merging this? |
Contributor
Author
|
@twalthr ping |
twalthr
approved these changes
Mar 13, 2019
Contributor
twalthr
left a comment
twalthr
left a comment
There was a problem hiding this comment.
Thank you @EronWright. Sorry for the delay. These changes make sense. Merging...
HuangZhenQiu
pushed a commit
to HuangZhenQiu/flink
that referenced
this pull request
Apr 22, 2019
…ent w/ user classloader Use the context classloader for all interactions with TableEnvironment. This closes apache#7389.
sunhaibotb
pushed a commit
to sunhaibotb/flink
that referenced
this pull request
May 8, 2019
…ent w/ user classloader Use the context classloader for all interactions with TableEnvironment. This closes apache#7389.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This issue was discovered in the course of implementing FLINK-9172, which introduces catalogs to the SQL Client environment. Catalogs are resolved to tables lazily, necessitating this patch.
The
LocalExecutorcalls into the table environment to execute queries, explain statements, and much more. Any call that involves resolving a descriptor to a factory implementation must be wrapped in the context classloader. Some of the calls already are wrapped (for resolving UDFs). With new functionality coming for resolving external catalogs with a descriptor (FLINK-9172), other call sites must be wrapped.This PR wraps all calls from local executor to table environment, for consistency. Seems wise to give the table environment maximum flexibility.
Brief change log
Note: based on PR #7388; please ignore changes outside of
LocalExecutorandExecutionContextand focus on 9637540.Verifying this change
This change is already covered by existing tests, such as
DeploymentTest, which exercises theLocalExecutor's classloading. Note that a subsequent PR will enhanceDeploymentTestfor more coverage (FLINK-9172).Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation