[FLINK-11240] [table] External Catalog Factory and Descriptor #7390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y table - fix the logic in supportsBatch to properly declare a batch-only table - adjust CommonTestData to provide batch-only or streaming-only tables Signed-off-by: EronWright <eronwright@gmail.com>
Signed-off-by: EronWright <eronwright@gmail.com>
…w/ user classloader - use the context classloader for all interactions with TableEnvironment Signed-off-by: EronWright <eronwright@gmail.com>
Signed-off-by: EronWright <eronwright@gmail.com>
- add is-streaming property for increased flexibility - fix style issue Signed-off-by: EronWright <eronwright@gmail.com>
EronWright
changed the title
Contributor
Author
|
@twalthr any reservation about merging this? |
Contributor
Author
|
@twalthr ping |
twalthr
approved these changes
Apr 2, 2019
Contributor
twalthr
left a comment
twalthr
left a comment
There was a problem hiding this comment.
Thanks @EronWright for this contribution. The changes look good to me. I will rebase this PR and merge this :) Sorry, for the delay.
HuangZhenQiu
pushed a commit
to HuangZhenQiu/flink
that referenced
this pull request
Apr 22, 2019
…iptor This closes apache#7390.
sunhaibotb
pushed a commit
to sunhaibotb/flink
that referenced
this pull request
May 8, 2019
…iptor This closes apache#7390.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Based on PR #7389; please see commits that are prefixed with FLINK-11240.
Implements the descriptor and factory infrastructure for external catalogs.
I found it counterproductive to involve
ConnectorDescriptorfor external catalogs. That type was designed to support a mix-and-match between connector and format. See FLINK-11241 for more.On the topic of the transition to
flink-table-common, I found it convenient to keep the new types inflink-tableuntilExternalCatalogmoves (FLINK-10755). Java was used whenever possible.Closes FLINK-11240.
Brief change log
ExternalCatalogDescriptorExternalCatalogDescriptorValidatorExternalCatalogFactoryTableFactoryUtil::findAndCreateExternalCatalogVerifying this change
This change added tests and can be verified as follows:
ExternalCatalogDescriptorTestfor descriptorsExternalCatalogFactoryServiceTestfor factory discoveryTestExternalCatalogFactoryfor test purposes which serves the catalog provided by the existingCommonTestData::getInMemoryTestCatalog.Does this pull request potentially affect one of the following parts:
@Public(Evolving): yesDocumentation