-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[FLINK-9172][table][sql-client] - Support external catalogs in SQL-Client #7393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…y table - fix the logic in supportsBatch to properly declare a batch-only table - adjust CommonTestData to provide batch-only or streaming-only tables Signed-off-by: EronWright <eronwright@gmail.com>
Signed-off-by: EronWright <eronwright@gmail.com>
…w/ user classloader - use the context classloader for all interactions with TableEnvironment Signed-off-by: EronWright <eronwright@gmail.com>
Signed-off-by: EronWright <eronwright@gmail.com>
- add is-streaming property for increased flexibility - fix style issue Signed-off-by: EronWright <eronwright@gmail.com>
…og via a descriptor - add ConnectExternalCatalogDescriptor - add ConnectExternalCatalogDescriptorTest - extend TableEnvironment with new connect method for catalogs Signed-off-by: EronWright <eronwright@gmail.com>
…og via a descriptor - add `TableEnvironment::listExternalCatalogs` Signed-off-by: EronWright <eronwright@gmail.com>
…og via a descriptor - fix scalastyle check Signed-off-by: EronWright <eronwright@gmail.com>
…Client - add `CatalogEntry` to configuration types - enhance `Environment` to include `catalogs` in overall configuration - enhance `ExecutionContext` to register the configured catalogs - cleanup test-table-factories.yaml (references to non-existent classes) - enhance `DependencyTest` to test discovery of catalog factories - enhance `EnvironmentTest` to test merging of catalog configuration - enhance `EnvironmentTest` to test the detection of duplicate catalogs/tables/functions - enhance `ExecutionContextTest` to test external catalogs - update test dependencies of sql-client to include flink-table's test classes (for `TestExternalCatalogFactory`) Signed-off-by: EronWright <eronwright@gmail.com>
|
@twalthr ping |
|
@twalthr @walterddr want's the status of this PR? |
|
This is a valuable contribution and definitely a feature that we want to have. My only concern here is that this PR exposes a catalog interface at another end which will be deprecated very soon as part of FLINK-11275. I would suggest to wait until FLINK-11476 has been merged. |
|
@EronWright it seems that the unified catalog API might be delayed and it makes sense to allow this feature sooner. I will review this pull request today. |
|
Thanks for your valuable contribution, @EronWright ! I left some comments in the JIRA ticket. Can you please rebase and adapt this PR? I can help review it as soon as you submit again. Thanks! |
What is the purpose of the change
Based on #7392. Please see commits prefixed with FLINK-9172.
Adds support for catalogs to the SQL Client environment file, using descriptors. For example, here's a sample catalog of type
taxi-databeing registered intosql-client-defaults.yaml:Brief change log
[FLINK-9172] [table] [sql-client] - Support external catalogs in SQL-Client
CatalogEntryto configuration typesEnvironmentto includecatalogsin overall configurationExecutionContextto register the configured catalogsTestExternalCatalogFactory)Verifying this change
This change added tests and can be verified as follows:
DependencyTestto test discovery of catalog factoriesEnvironmentTestto test merging of catalog configurationEnvironmentTestto test the detection of duplicate catalogs/tables/functionsExecutionContextTestto test external catalogsDoes this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation