Skip to content

[CORE] Fix FallbackByNativeValidation attempts to offload a whole tree than a single node#10696

Merged
zhztheplayer merged 1 commit intoapache:mainfrom
zhztheplayer:wip-fix-validator
Sep 17, 2025
Merged

[CORE] Fix FallbackByNativeValidation attempts to offload a whole tree than a single node#10696
zhztheplayer merged 1 commit intoapache:mainfrom
zhztheplayer:wip-fix-validator

Conversation

@zhztheplayer
Copy link
Copy Markdown
Member

@zhztheplayer zhztheplayer commented Sep 12, 2025

As title. FallbackByNativeValidation is supposed to handle a single node. We currently pass a tree to the offload attempt which overkills the goal. It's functioning but may impact the performance.

The patch fixes the issue.

@github-actions github-actions bot added the CORE works for Gluten Core label Sep 12, 2025
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

…e than a single node

As title. FallbackByNativeValidation is supposed to handle a single node. We currently pass a tree to the offload attempt.
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@zhztheplayer zhztheplayer marked this pull request as ready for review September 15, 2025 09:55
Copy link
Copy Markdown
Contributor

@zml1206 zml1206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@zhztheplayer
Copy link
Copy Markdown
Member Author

Thanks @zml1206 .

@zhztheplayer zhztheplayer merged commit 0d72a86 into apache:main Sep 17, 2025
154 of 157 checks passed
wForget pushed a commit to wForget/gluten that referenced this pull request Sep 23, 2025
@wForget wForget mentioned this pull request Sep 23, 2025
wForget pushed a commit to wForget/gluten that referenced this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CORE works for Gluten Core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants