Skip to content

[CORE] Fix FallbackByNativeValidation attempts to offload a whole tree than a single node #10696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhztheplayer merged 1 commit into from
Sep 17, 2025
Merged

[CORE] Fix FallbackByNativeValidation attempts to offload a whole tree than a single node #10696

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...-substrait/src/main/scala/org/apache/gluten/extension/columnar/validator/Validators.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import org.apache.gluten.config.GlutenConfig
import org.apache.gluten.execution._
import org.apache.gluten.expression.ExpressionUtils
import org.apache.gluten.extension.columnar.FallbackTags
import org.apache.gluten.extension.columnar.heuristic.LegacyOffload
import org.apache.gluten.extension.columnar.offload.OffloadSingleNode
import org.apache.gluten.sql.shims.SparkShimLoader

Expand Down Expand Up @@ -232,7 +231,6 @@ object Validators {
private class FallbackByNativeValidation(offloadRules: Seq[OffloadSingleNode])
extends Validator
with Logging {
private val offloadAttempt: LegacyOffload = LegacyOffload(offloadRules)
override def validate(plan: SparkPlan): Validator.OutCome = {
val offloadedNode = offloadAttempt.apply(plan)
val out = offloadedNode match {
Expand All @@ -244,6 +242,14 @@ object Validators {
}
out
}

private val offloadAttempt: SparkPlan => SparkPlan = {
node =>
offloadRules.foldLeft(node) {
case (node, rule) =>
rule.offload(node)
}
}
}

/**
Expand Down
Loading