Skip to content

[GLUTEN-7706][CORE] Support Spark-344 + JDK17#7789

Merged
FelixYBW merged 22 commits intoapache:mainfrom
zhouyuan:wip_spark344
Jan 17, 2025
Merged

[GLUTEN-7706][CORE] Support Spark-344 + JDK17#7789
FelixYBW merged 22 commits intoapache:mainfrom
zhouyuan:wip_spark344

Conversation

@zhouyuan
Copy link
Copy Markdown
Member

@zhouyuan zhouyuan commented Nov 3, 2024

What changes were proposed in this pull request?

Support Spark-344 + JDK17

How was this patch tested?

pass GHA tests

@github-actions github-actions bot added the CORE works for Gluten Core label Nov 3, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 3, 2024

#7706

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 3, 2024

Run Gluten Clickhouse CI

@github-actions github-actions bot added the INFRA label Nov 3, 2024
@github-actions

This comment was marked as duplicate.

@apache apache deleted a comment from github-actions bot Nov 4, 2024
@apache apache deleted a comment from github-actions bot Nov 4, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 5, 2024

Run Gluten Clickhouse CI

@gaoyangxiaozhu
Copy link
Copy Markdown
Contributor

what's the specifc reason here to switch to 3.4.4 ?

@zhouyuan zhouyuan closed this Nov 18, 2024
@zhouyuan zhouyuan reopened this Dec 9, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 9, 2024

Run Gluten Clickhouse CI on x86

4 similar comments
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 9, 2024

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 9, 2024

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 8, 2025

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 8, 2025

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 8, 2025

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 8, 2025

Run Gluten Clickhouse CI on x86

2 similar comments
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 8, 2025

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 8, 2025

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 9, 2025

Run Gluten Clickhouse CI on x86

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@github-actions github-actions bot removed the VELOX label Jan 14, 2025
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
@apache apache deleted a comment from github-actions bot Jan 15, 2025
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

This reverts commit 1e504a3.
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@zhouyuan zhouyuan changed the title [GLUTEN-7706][CORE] Support Spark-344 [GLUTEN-7706][CORE] Support Spark-344 + JDK17 Jan 17, 2025
@zhouyuan zhouyuan marked this pull request as ready for review January 17, 2025 00:25
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@FelixYBW FelixYBW merged commit c19cc9c into apache:main Jan 17, 2025
@FelixYBW
Copy link
Copy Markdown
Contributor

Thank you, Yuan

export JAVA_HOME=/usr/lib/jvm/java-17-openjdk
export SPARK_HOME=/opt/shims/spark34/spark_home/
ls -l /opt/shims/spark34/spark_home/
$MVN_CMD clean test -Pspark-3.4 -Pjava-17 -Pbackends-velox -Pceleborn -Piceberg -Pdelta -Phudi -Pspark-ut \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems Spark 344 UT will only run with jdk17, will we drop UT+jdk8 support in the future?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems Spark 344 UT will only run with jdk17, will we drop UT+jdk8 support in the future?

Hi @Yohahaha,

In general we are trying to bump the JDK support in 1.4 release, due to many dependent libs dropped JDK8 support.

  • The main reason for this bump is due to iceberg dropped JDK8 support starts from 1.7.0(https://lists.apache.org/thread/xd4sjd0cx010qcv9qmlt89zdx4s1cyp4). JDK8 should be working if -Piceberg is not activated
  • based on my local tests, JDK11 is also working, the current latest LTS JDK17 seems more preferred based on what I collected so far
  • If JDK8 requirements are strong in the community, we could add back the JDK8 based unit tests CI(without -Piceberg)

Cc: @weiting-chen

Thanks, -yuan

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the explanation! @zhouyuan

based on my local tests, JDK11 is also working, the current latest LTS JDK17 seems more preferred based on what I collected so far

yes, spark 4.0 requires JDK17+

baibaichen pushed a commit to baibaichen/gluten that referenced this pull request Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CORE works for Gluten Core DOCS INFRA TOOLS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants