[VL][CI] Use a unified docker image for Spark tests#8605
Merged
philo-he merged 3 commits intoapache:mainfrom Mar 18, 2025
Merged
[VL][CI] Use a unified docker image for Spark tests#8605philo-he merged 3 commits intoapache:mainfrom
philo-he merged 3 commits intoapache:mainfrom
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This reverts commit 18f1510.
zhouyuan
approved these changes
Mar 18, 2025
Member
zhouyuan
left a comment
There was a problem hiding this comment.
+1
I remember there is some in-compatible arrow class reported previously. If all tests are passing now so should be all good
Contributor
|
===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====
|
Contributor
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In #7789, Spark-3.4.4 support is added and JDK-17 docker is used to avoid some issues caused by arrow. This pr changes to use the unified docker image and switches JDK version before running the test, which can reduce the efforts a bit for maintaining docker images.
I cannot figure out the reason why this way didn't pass in previous test. Maybe, we can land this pr firstly and continue observing the CI feedback while still keeping the JDK-17 docker image available in docker hub for some time.
How was this patch tested?
CI.