[GLUTEN-8453] [VL] Allow Heavy Batch to be Processed by ColumnarCachedBatchSerializer#8454
Conversation
|
|
||
| import org.apache.gluten.backendsapi.BackendsApiManager | ||
| import org.apache.gluten.columnarbatch.ColumnarBatches | ||
| import org.apache.gluten.columnarbatch.{ColumnarBatches, VeloxColumnarBatches} |
There was a problem hiding this comment.
@zhztheplayer Ok to add VeloxColumnarBatches here?
There was a problem hiding this comment.
Yes it's normal to call the utility from Velox backend code. However it seems like discussible on whether to rely on isLightBatch / isHeavyBatch to add conditional transitions.
@ArnavBalyan Would you like to help check if we can somehow add explicit transition nodes (LoadArrowData / OffloadArrowData) into query plan instead of the PR's change? Or is the last Note. in pr description meant for something similar? Thanks!
There was a problem hiding this comment.
Could also refer to a previous effort #7313 if needed.
There was a problem hiding this comment.
Thanks for the review @FelixYBW @zhztheplayer!
Yes, the note was meant for that. Ideally the transitions should have added the correct transition node before this, However the serializer is a special case since it's not an operator and does not extend the GlutenPlan, I have some ideas to explore this which may require some design changes in the serializer to make it work with transitions.
Would it be possible to merge this for now since the ColumnarRange operator depends on it and I'll work on the serializer compatibility for transitions, let me know what you think thanks!
There was a problem hiding this comment.
However the serializer is a special case since it's not an operator and does not extend the GlutenPlan
Agreed. The code path is different. Thanks for figuring out on this.
Do you think we can add a UT for the change in this PR? If this can be considered an individual fix?
There was a problem hiding this comment.
Sure let me add it in the ColumnarRangeExec, since it already has the failing UT thanks!
There was a problem hiding this comment.
Yes please feel free to move forward to the Range PR. I am also testing the relevant code and will help add a test case here.
…for limited use cases (#8463)
Uh oh!
There was an error while loading. Please reload this page.