HBASE-25663 Make graceful_stop localhostname compare match even if fqdn and unload regions #3053

javierluca · 2021-03-16T05:43:44Z

Previous: #3048

Adding it again because it was revered: c36e40e

And ddressing this issue: #3048 (review) (#3048 (comment))

Apache-HBase · 2021-03-16T05:46:09Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		1m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3053/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3053
Optional Tests
uname	Linux 97ff1b847090 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `59ec375`
Max. process+thread count	53 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3053/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-03-16T05:47:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 21s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		2m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3053/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3053
Optional Tests
uname	Linux 6a2a01ffe08e 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `59ec375`
Max. process+thread count	41 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3053/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-03-16T05:47:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 10s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	shelldocs	0m 0s	Shelldocs was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
-0 ⚠️	shellcheck	0m 1s	The patch generated 10 new + 23 unchanged - 15 fixed = 33 total (was 38)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
		_ Other Tests _
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		2m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3053/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3053
Optional Tests	dupname asflicense shellcheck shelldocs
uname	Linux 1ae3ee9f020e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `59ec375`
shellcheck	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3053/1/artifact/yetus-general-check/output/diff-patch-shellcheck.txt
Max. process+thread count	51 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3053/1/console
versions	git=2.17.1 maven=3.6.3 shellcheck=0.4.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

javierluca · 2021-03-16T05:54:52Z

cc @saintstack
First commit revives your previous changes.
Second one addresses the commented issue with RegionMover.

ekrettek · 2021-03-16T09:54:03Z

bin/graceful_stop.sh

 fi

+unload_hostname="$hostname"
+if [[ "$hostname" -eq "localhost" ]]; then


You’ll want to use == here because it’s comparing two strings

Apache-HBase · 2021-03-16T10:03:00Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		1m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3053/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3053
Optional Tests
uname	Linux dc75a56bd3a7 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `59ec375`
Max. process+thread count	52 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3053/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-03-16T10:04:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		2m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3053/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3053
Optional Tests
uname	Linux 98dc95485a9f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `59ec375`
Max. process+thread count	47 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3053/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-03-16T10:04:46Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	shelldocs	0m 0s	Shelldocs was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
-0 ⚠️	shellcheck	0m 1s	The patch generated 9 new + 23 unchanged - 15 fixed = 32 total (was 38)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
		_ Other Tests _
+1 💚	asflicense	0m 18s	The patch does not generate ASF License warnings.
		3m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3053/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3053
Optional Tests	dupname asflicense shellcheck shelldocs
uname	Linux f87e651b1e9e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `59ec375`
shellcheck	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3053/2/artifact/yetus-general-check/output/diff-patch-shellcheck.txt
Max. process+thread count	48 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3053/2/console
versions	git=2.17.1 maven=3.6.3 shellcheck=0.4.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

javierluca · 2021-03-16T12:06:30Z

Mmmh I might have misunderstood the "localhost" mode.
My intention is to be able to graceful_restart a local RegionServer in a secure environment where we can't use ssh to restart remotely.
However, seems the localhost mode is actually meant to be used by pseudo-distributed mode:

And in localhost mode, regionservers.sh uses hard-coded ports:

hbase/bin/regionservers.sh

Lines 61 to 64 in d74ae15

    
           if [ "$regionservers" = "localhost" ]; then 
        
             HBASE_REGIONSERVER_ARGS="\ 
        
               -Dhbase.regionserver.port=16020 \ 
        
               -Dhbase.regionserver.info.port=16030"

This is very confusing, because if someone has configured other ports and restart in localhost mode, it will see the ports changing after the restart.

Let me rethink about a proper solution or just leave the original proposed change #2973 (pushed by @saintstack in this commit 59ec375).

So please don't merge this yet (I may close it an open with a new solution).

javierluca · 2021-03-16T12:51:56Z

Sorry for so many PRs, proceeding here: #3054

saintstack and others added 2 commits March 16, 2021 14:28

HBASE-25663 Make graceful_stop localhostname compare match even if fq…

b8a4a60

…dn (apache#3048)

HBASE-25663 Use fqdn when unloading regions in graceful_stop.sh

ef3a172

javierluca mentioned this pull request Mar 16, 2021

HBASE-25663 Make graceful_stop localhostname compare match even if fqdn #3048

Merged

javierluca mentioned this pull request Mar 16, 2021

HBASE-25594 graceful_stop.sh fails to unload regions when ran at localhost #2973

Closed

ekrettek reviewed Mar 16, 2021

View reviewed changes

fix: use == for string comparison

992daf2

javierluca closed this Mar 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-25663 Make graceful_stop localhostname compare match even if fqdn and unload regions #3053

HBASE-25663 Make graceful_stop localhostname compare match even if fqdn and unload regions #3053

Uh oh!

javierluca commented Mar 16, 2021 •

edited

Loading

Uh oh!

Apache-HBase commented Mar 16, 2021

Uh oh!

Apache-HBase commented Mar 16, 2021

Uh oh!

Apache-HBase commented Mar 16, 2021

Uh oh!

javierluca commented Mar 16, 2021 •

edited

Loading

Uh oh!

ekrettek Mar 16, 2021

Uh oh!

Apache-HBase commented Mar 16, 2021

Uh oh!

Apache-HBase commented Mar 16, 2021

Uh oh!

Apache-HBase commented Mar 16, 2021

Uh oh!

javierluca commented Mar 16, 2021 •

edited

Loading

Uh oh!

javierluca commented Mar 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

HBASE-25663 Make graceful_stop localhostname compare match even if fqdn and unload regions #3053

HBASE-25663 Make graceful_stop localhostname compare match even if fqdn and unload regions #3053

Uh oh!

Conversation

javierluca commented Mar 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Apache-HBase commented Mar 16, 2021

Uh oh!

Apache-HBase commented Mar 16, 2021

Uh oh!

Apache-HBase commented Mar 16, 2021

Uh oh!

javierluca commented Mar 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ekrettek Mar 16, 2021

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Mar 16, 2021

Uh oh!

Apache-HBase commented Mar 16, 2021

Uh oh!

Apache-HBase commented Mar 16, 2021

Uh oh!

javierluca commented Mar 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

javierluca commented Mar 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

javierluca commented Mar 16, 2021 •

edited

Loading

javierluca commented Mar 16, 2021 •

edited

Loading

javierluca commented Mar 16, 2021 •

edited

Loading