Skip to content

HBASE-25663 Make graceful_stop localhostname compare match even if fqdn and unload regions #3053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javierluca wants to merge 3 commits into from
Closed

HBASE-25663 Make graceful_stop localhostname compare match even if fqdn and unload regions #3053

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8a4a60
HBASE-25663 Make graceful_stop localhostname compare match even if fq…
saintstack Mar 15, 2021
ef3a172
HBASE-25663 Use fqdn when unloading regions in graceful_stop.sh
Mar 16, 2021
992daf2
fix: use == for string comparison
Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 14 additions & 41 deletions bin/graceful_stop.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@
# * limitations under the License.
# */

# Move regions off a server then stop it. Optionally restart and reload.
# Turn off the balancer before running this script.
# Move regions off a server then stop it. Optionally restart and reload.
function usage {
echo "Usage: graceful_stop.sh [--config <conf-dir>] [-e] [--restart [--reload]] [--thrift] \
[--rest] [-n |--noack] [--maxthreads <number of threads>] [--movetimeout <timeout in seconds>] \
Expand All @@ -33,7 +32,7 @@ moving regions"
echo " maxthreads xx Limit the number of threads used by the region mover. Default value is 1."
echo " movetimeout xx Timeout for moving regions. If regions are not moved by the timeout value,\
exit with error. Default value is INT_MAX."
echo " hostname Hostname of server we are to stop"
echo " hostname Hostname to stop; match what HBase uses; pass 'localhost' if local to avoid ssh"
echo " e|failfast Set -e so exit immediately if any command exits with non-zero status"
echo " nob|nobalancer Do not manage balancer states. This is only used as optimization in \
rolling_restart.sh to avoid multiple calls to hbase shell"
Expand Down Expand Up @@ -102,13 +101,6 @@ fi
hostname=$1
filename="/tmp/$hostname"

local=
localhostname=`/bin/hostname -f`

if [ "$localhostname" == "$hostname" ]; then
local=true
fi

if [ "$nob" == "true" ]; then
log "[ $0 ] skipping disabling balancer -nob argument is used"
HBASE_BALANCER_STATE=false
Expand All @@ -118,8 +110,13 @@ else
log "Previous balancer state was $HBASE_BALANCER_STATE"
fi

unload_hostname="$hostname"
if [[ "$hostname" == "localhost" ]]; then
# Need fqdn to remove the host Region server from target Region Servers list
unload_hostname=`/bin/hostname -f`
fi
unload_args="--filename $filename --maxthreads $maxthreads $noack --operation unload \
--timeout $movetimeout --regionserverhost $hostname"
--timeout $movetimeout --regionserverhost $unload_hostname"

if [ "$designatedfile" != "" ]; then
unload_args="$unload_args --designatedfile $designatedfile"
Expand All @@ -139,49 +136,25 @@ hosts="/tmp/$(basename $0).$$.tmp"
echo $hostname >> $hosts
if [ "$thrift" != "" ]; then
log "Stopping thrift server on $hostname"
if [ "$local" == true ]; then
"$bin"/hbase-daemon.sh --config ${HBASE_CONF_DIR} stop thrift
else
"$bin"/hbase-daemons.sh --config ${HBASE_CONF_DIR} --hosts ${hosts} stop thrift
fi
"$bin"/hbase-daemons.sh --config ${HBASE_CONF_DIR} --hosts ${hosts} stop thrift
fi
if [ "$rest" != "" ]; then
log "Stopping rest server on $hostname"
if [ "$local" == true ]; then
"$bin"/hbase-daemon.sh --config ${HBASE_CONF_DIR} stop rest
else
"$bin"/hbase-daemons.sh --config ${HBASE_CONF_DIR} --hosts ${hosts} stop rest
fi
"$bin"/hbase-daemons.sh --config ${HBASE_CONF_DIR} --hosts ${hosts} stop rest
fi
log "Stopping regionserver on $hostname"
if [ "$local" == true ]; then
"$bin"/hbase-daemon.sh --config ${HBASE_CONF_DIR} stop regionserver
else
"$bin"/hbase-daemons.sh --config ${HBASE_CONF_DIR} --hosts ${hosts} stop regionserver
fi
"$bin"/hbase-daemons.sh --config ${HBASE_CONF_DIR} --hosts ${hosts} stop regionserver
if [ "$restart" != "" ]; then
log "Restarting regionserver on $hostname"
if [ "$local" == true ]; then
"$bin"/hbase-daemon.sh --config ${HBASE_CONF_DIR} start regionserver
else
"$bin"/hbase-daemons.sh --config ${HBASE_CONF_DIR} --hosts ${hosts} start regionserver
fi
"$bin"/hbase-daemons.sh --config ${HBASE_CONF_DIR} --hosts ${hosts} start regionserver
if [ "$thrift" != "" ]; then
log "Restarting thrift server on $hostname"
# -b 0.0.0.0 says listen on all interfaces rather than just default.
if [ "$local" == true ]; then
"$bin"/hbase-daemon.sh --config ${HBASE_CONF_DIR} start thrift -b 0.0.0.0
else
"$bin"/hbase-daemons.sh --config ${HBASE_CONF_DIR} --hosts ${hosts} start thrift -b 0.0.0.0
fi
"$bin"/hbase-daemons.sh --config ${HBASE_CONF_DIR} --hosts ${hosts} start thrift -b 0.0.0.0
fi
if [ "$rest" != "" ]; then
log "Restarting rest server on $hostname"
if [ "$local" == true ]; then
"$bin"/hbase-daemon.sh --config ${HBASE_CONF_DIR} start rest
else
"$bin"/hbase-daemons.sh --config ${HBASE_CONF_DIR} --hosts ${hosts} start rest
fi
"$bin"/hbase-daemons.sh --config ${HBASE_CONF_DIR} --hosts ${hosts} start rest
fi
if [ "$reload" != "" ]; then
log "Reloading $hostname region(s)"
Expand Down