HIVE-26990 - Upgrade Iceberg from 1.0.0 to 1.1.0 #3968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
added
tests pending
tests failed
and removed
tests unstable
tests pending
labels
This reverts commit 67506d6.
kgyrtkirk
added
tests failed
tests pending
tests unstable
and removed
tests pending
tests failed
labels
InvisibleProgrammer
changed the title
InvisibleProgrammer
changed the title
kgyrtkirk
added
tests failed
tests pending
tests unstable
tests passed
and removed
tests pending
tests failed
tests unstable
labels
ayushtkn
reviewed
Feb 8, 2023
Member
ayushtkn
left a comment
ayushtkn
left a comment
There was a problem hiding this comment.
Changes Looks good.
We have patched HadoopInputFile as well in Hive. We should sync that as well with the 1.1.0 code.
Guess this commit is the only extra one:
apache/iceberg@1bdc699
Can you check if that can be included?
Member
|
Looks like apache/iceberg#5670 was included only downstream, I guess we can disregard it for now, but it might bite us eventually. |
|
Kudos, SonarCloud Quality Gate passed!
|
yeahyung
pushed a commit
to yeahyung/hive
that referenced
this pull request
Jul 20, 2023
…t Miskolczi, reviewed by Ayush Saxena) * Update iceberg version * Core: Use CharSequenceSet instead of Set<CharSequence> * Flink: Add SupportsRowPosition to Avro reader to fix position deletes * Core: Deprecate functions in DeleteWriters (apache#5771) * API: Fix Transform backward compatibility in PartitionSpec * Core: Avoid extra getFileStatus call in HadoopInputFile
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Dec 19, 2023
…t Miskolczi, reviewed by Ayush Saxena) * Update iceberg version * Core: Use CharSequenceSet instead of Set<CharSequence> * Flink: Add SupportsRowPosition to Avro reader to fix position deletes * Core: Deprecate functions in DeleteWriters (apache#5771) * API: Fix Transform backward compatibility in PartitionSpec * Core: Avoid extra getFileStatus call in HadoopInputFile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iceberg released 1.1.0. Hive currently uses 1.0.0
What changes were proposed in this pull request?
Upgrading the iceberg/pom.xml maven dependency and porting/fixing necessary changes to be able to make all tests green.
Some comments about the changes:
Why are the changes needed?
To make sure the code compiles and all tests are green.
Does this PR introduce any user-facing change?
There will be some changes in describe metadata tables. See c13294b
How was this patch tested?
Ran all the existing tests.