Conversation
Codecov Report
@@ Coverage Diff @@
## master #1770 +/- ##
============================================
+ Coverage 63.26% 70.84% +7.57%
- Complexity 684 976 +292
============================================
Files 443 446 +3
Lines 37738 37802 +64
Branches 5381 5392 +11
============================================
+ Hits 23875 26780 +2905
+ Misses 11247 8295 -2952
- Partials 2616 2727 +111
Continue to review full report at Codecov.
|
| mvn clean package -DskipTests | ||
| mv "$(find hugegraph-*.tar.gz | head -1)" hugegraph-${TAG_NAME/#v/}.tar.gz | ||
|
|
||
| - name: Rename file |
There was a problem hiding this comment.
why need to split into 2 stages? can put "mvn clean package -DskipTests" into "Rename file" stage?
There was a problem hiding this comment.
because of the "Rename file" operation is not unessential
| mv "$(find hugegraph-*.tar.gz | head -1)" hugegraph-${TAG_NAME/#v/}.tar.gz | ||
|
|
||
| - name: Rename file | ||
| if: contains(env.TAG_NAME, "-") |
There was a problem hiding this comment.
fixed error mv: '***-0.12.0.tar.gz' and '***-0.12.0.tar.gz' are the same file
.github/workflows/release.yml
Outdated
| if: contains(env.TAG_NAME, "-") | ||
| run: mv "$(find hugegraph-*.tar.gz | head -1)" hugegraph-${TAG_NAME/#v/}.tar.gz | ||
|
|
||
| - uses: xresloader/upload-to-github-release@master |
There was a problem hiding this comment.
also add name "Upload to GitHub"
| mvn clean package -DskipTests | ||
| mv "$(find hugegraph-*.tar.gz | head -1)" hugegraph-${TAG_NAME/#v/}.tar.gz | ||
|
|
||
| - name: Rename file |
| mv "$(find hugegraph-*.tar.gz | head -1)" hugegraph-${TAG_NAME/#v/}.tar.gz | ||
|
|
||
| - name: Rename file | ||
| if: contains(env.TAG_NAME, "-") |
There was a problem hiding this comment.
only need to rename when TAG_NAME is like 0.12.0-b2?
|
CLA Assistant Lite bot Good! All Contributors have signed the CLA. |
|
I have read the CLA Document and I hereby sign the CLA |
3 participants
fix #1766