Skip to content

fix release ci #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
javeme merged 2 commits into from
Mar 21, 2022
Merged

fix release ci #1770

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
317c610
fix release ci
coderzc Feb 17, 2022
572de9b
add stage name
coderzc Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,13 @@ jobs:
- name: Package
run: |
mvn clean package -DskipTests
mv "$(find hugegraph-*.tar.gz | head -1)" hugegraph-${TAG_NAME/#v/}.tar.gz

- uses: xresloader/upload-to-github-release@master
- name: Rename file
Copy link
Copy Markdown
Contributor

@javeme javeme Mar 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why need to split into 2 stages? can put "mvn clean package -DskipTests" into "Rename file" stage?

Copy link
Copy Markdown
Member Author

@coderzc coderzc Mar 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because of the "Rename file" operation is not unessential

Copy link
Copy Markdown
Contributor

@javeme javeme Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

if: contains(env.TAG_NAME, "-")
Copy link
Copy Markdown
Contributor

@javeme javeme Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed error mv: '***-0.12.0.tar.gz' and '***-0.12.0.tar.gz' are the same file

Copy link
Copy Markdown
Contributor

@javeme javeme Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only need to rename when TAG_NAME is like 0.12.0-b2?

Copy link
Copy Markdown
Member Author

@coderzc coderzc Mar 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

run: mv "$(find hugegraph-*.tar.gz | head -1)" hugegraph-${TAG_NAME/#v/}.tar.gz

- name: Upload to GitHub
uses: xresloader/upload-to-github-release@master
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
Expand Down