Closed
Conversation
Member
Author
|
I have read the CLA Document and I hereby sign the CLA |
Member
Author
|
check result: |
javeme
approved these changes
Apr 19, 2022
imbajin
approved these changes
Apr 19, 2022
coderzc
approved these changes
Apr 19, 2022
Codecov Report
@@ Coverage Diff @@
## master #1829 +/- ##
============================================
+ Coverage 70.70% 70.74% +0.03%
- Complexity 980 982 +2
============================================
Files 447 447
Lines 38041 38041
Branches 5389 5389
============================================
+ Hits 26897 26911 +14
+ Misses 8508 8496 -12
+ Partials 2636 2634 -2
Continue to review full report at Codecov.
|
javeme
reviewed
Apr 26, 2022
| } | ||
| return IteratorUtils.of(row.getLong(0)); | ||
| }); | ||
| Row row = rs.one(); |
Contributor
There was a problem hiding this comment.
can we keep the origin indentation style?
javeme
approved these changes
Apr 26, 2022
imbajin
reviewed
Apr 26, 2022
Comment on lines
+111
to
+115
| if (row == null) { | ||
| return IteratorUtils.of(aggregate.defaultValue()); | ||
| } | ||
| return IteratorUtils.of(row.getLong(0)); | ||
| }); |
Member
There was a problem hiding this comment.
how could it add 8 space in IDE's behavior? seems it's confuse
Member
Author
|
see #1847 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix cassandra code checkstyle