-
Notifications
You must be signed in to change notification settings - Fork 590
fix cassandra code checkstyle #1829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
db1fa54
fix cassandra code checkstyle
z7658329 e60ba1f
Merge branch 'apache:master' into master
z7658329 c645b93
Merge branch 'apache:master' into master
z7658329 717adef
empty commit
z7658329 921ceb1
Merge branch 'apache:master' into master
z7658329 0699970
empty commit
z7658329 f0e85a2
Merge branch 'apache:master' into master
z7658329 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -107,12 +107,12 @@ public Number queryNumber(CassandraSessionPool.Session session, | |
| statement.setReadTimeoutMillis(timeout * 1000); | ||
| return session.query(statement); | ||
| }, (q, rs) -> { | ||
| Row row = rs.one(); | ||
| if (row == null) { | ||
| return IteratorUtils.of(aggregate.defaultValue()); | ||
| } | ||
| return IteratorUtils.of(row.getLong(0)); | ||
| }); | ||
| Row row = rs.one(); | ||
| if (row == null) { | ||
| return IteratorUtils.of(aggregate.defaultValue()); | ||
| } | ||
| return IteratorUtils.of(row.getLong(0)); | ||
| }); | ||
|
Comment on lines
+111
to
+115
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. how could it add 8 space in IDE's behavior? seems it's confuse |
||
| return aggregate.reduce(results); | ||
| } | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we keep the origin indentation style?